module: expose exports conditions to loaders #31303

jkrems · 2020-01-10T18:28:12Z

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

jkrems · 2020-01-10T18:28:26Z

/cc @nodejs/modules-active-members

lib/internal/modules/esm/resolve.js

src/module_wrap.cc

guybedford · 2020-01-11T07:00:00Z

Nice work, this approach seems great!

test/fixtures/es-module-loaders/loader-with-custom-condition.mjs

jkrems · 2020-02-10T18:19:03Z

Cleaned up and marking as ready for review. I updated the implementation to use a std::set instead of V8::Set. In the process the conditions cache got moved into C++, JS only creates the key (\0-separated condition names).

guybedford

Seems like a nice approach.

src/module_wrap.cc

test/fixtures/es-module-loaders/loader-with-custom-condition.mjs

jkrems · 2020-03-02T18:07:28Z

Ping @nodejs/modules-active-members, this is still lacking some reviews/approvals before we can land it. Adding it to the agenda in case it's still open by our next meeting. :)

bmeck

I really like this PR! This falls into some things we are starting to see from the community about custom conditions like https://twitter.com/sebmarkbage/status/1234223477424447488 .

test/fixtures/es-module-loaders/loader-with-custom-condition.mjs

guybedford

Would be great to see this moving forward :)

src/module_wrap.cc

test/fixtures/es-module-loaders/loader-with-custom-condition.mjs

doc/api/esm.md

lib/internal/modules/esm/resolve.js

nodejs-github-bot · 2020-03-29T21:52:33Z

CI: https://ci.nodejs.org/job/node-test-pull-request/30219/ (:heavy_check_mark:)

lib/internal/modules/esm/loader.js

nodejs-github-bot · 2020-03-31T16:35:47Z

CI: https://ci.nodejs.org/job/node-test-pull-request/30286/

jkrems · 2020-03-31T17:16:19Z

There's one C++ test that seems to fail on linuxone. I look into it briefly but I don't see a clear reason why it would fail (or what the failure really means). I'm surprised that this PR would affect low-level worker interactions but can't rule it out.

addaleax · 2020-04-02T16:11:20Z

@jkrems See #32563 – I just landed a fix for that. :) Is this still ready to land, apart from waiting for a green CI?

nodejs-github-bot · 2020-04-02T16:12:06Z

CI: https://ci.nodejs.org/job/node-test-pull-request/30370/

jkrems · 2020-04-02T16:12:52Z

Is this still ready to land, apart from waiting for a green CI?

Yes! This should be good to go, assuming CI comes back green.

(And thanks for being on top of these build failures, much appreciated. :))

nodejs-github-bot · 2020-04-02T23:08:26Z

CI: https://ci.nodejs.org/job/node-test-pull-request/30394/

PR-URL: #31303 Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>

addaleax · 2020-04-02T23:29:50Z

Landed in 9129ab1

PR-URL: #31303 Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>

PR-URL: nodejs#31303 Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>

PR-URL: #31303 Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. esm Issues and PRs related to the ECMAScript Modules implementation. labels Jan 10, 2020

jkrems commented Jan 10, 2020

View reviewed changes

lib/internal/modules/esm/resolve.js Outdated Show resolved Hide resolved

addaleax reviewed Jan 11, 2020

View reviewed changes

GeoffreyBooth reviewed Jan 11, 2020

View reviewed changes

test/fixtures/es-module-loaders/loader-with-custom-condition.mjs Outdated Show resolved Hide resolved

sparebytes mentioned this pull request Jan 21, 2020

[Case Study] Exports Support yarnpkg/berry#650

Closed

1 task

jkrems force-pushed the loader-conditions branch 9 times, most recently from d05c96e to 66ebe58 Compare February 10, 2020 18:13

jkrems marked this pull request as ready for review February 10, 2020 18:18

guybedford reviewed Feb 10, 2020

View reviewed changes

src/module_wrap.cc Outdated Show resolved Hide resolved

test/fixtures/es-module-loaders/loader-with-custom-condition.mjs Outdated Show resolved Hide resolved

jkrems force-pushed the loader-conditions branch from 66ebe58 to 7c15d59 Compare March 2, 2020 18:02

jkrems added the modules-agenda Issues and PRs to discuss during the meetings of the Modules team. label Mar 2, 2020

bmeck approved these changes Mar 2, 2020

View reviewed changes

This comment has been minimized.

Sign in to view

jkrems added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 2, 2020

GeoffreyBooth reviewed Mar 2, 2020

View reviewed changes

test/fixtures/es-module-loaders/loader-with-custom-condition.mjs Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

guybedford approved these changes Mar 3, 2020

View reviewed changes

src/module_wrap.cc Outdated Show resolved Hide resolved

test/fixtures/es-module-loaders/loader-with-custom-condition.mjs Outdated Show resolved Hide resolved

bmeck reviewed Mar 3, 2020

View reviewed changes

doc/api/esm.md Show resolved Hide resolved

jkrems force-pushed the loader-conditions branch from 8703335 to 19b2f4f Compare March 17, 2020 17:42

nodejs deleted a comment from jkrems Mar 20, 2020

guybedford approved these changes Mar 23, 2020

View reviewed changes

lib/internal/modules/esm/resolve.js Outdated Show resolved Hide resolved

lib/internal/modules/esm/resolve.js Show resolved Hide resolved

jkrems force-pushed the loader-conditions branch from 19b2f4f to a14ba1e Compare March 30, 2020 16:16

This comment has been minimized.

Sign in to view

jkrems force-pushed the loader-conditions branch from a14ba1e to 8108485 Compare March 30, 2020 16:31

himself65 reviewed Mar 30, 2020

View reviewed changes

lib/internal/modules/esm/loader.js Show resolved Hide resolved

jkrems force-pushed the loader-conditions branch from 8108485 to 2267d17 Compare March 30, 2020 17:13

This comment has been minimized.

Sign in to view

module: expose exports conditions to loaders

1549bc4

jkrems force-pushed the loader-conditions branch from 2267d17 to 1549bc4 Compare March 31, 2020 16:34

addaleax closed this Apr 2, 2020

targos mentioned this pull request Apr 13, 2020

v13.13.0 release proposal #32813

Merged

targos removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 25, 2020

targos mentioned this pull request May 2, 2020

v12.17.0 release proposal #33197

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

module: expose exports conditions to loaders #31303

module: expose exports conditions to loaders #31303

jkrems commented Jan 10, 2020 •

edited

Loading

jkrems commented Jan 10, 2020

guybedford commented Jan 11, 2020

jkrems commented Feb 10, 2020

guybedford left a comment

jkrems commented Mar 2, 2020

bmeck left a comment

This comment has been minimized.

This comment has been minimized.

guybedford left a comment

nodejs-github-bot commented Mar 29, 2020 •

edited by addaleax

Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

nodejs-github-bot commented Mar 31, 2020

jkrems commented Mar 31, 2020

addaleax commented Apr 2, 2020

nodejs-github-bot commented Apr 2, 2020

jkrems commented Apr 2, 2020 •

edited

Loading

nodejs-github-bot commented Apr 2, 2020

addaleax commented Apr 2, 2020

module: expose exports conditions to loaders #31303

module: expose exports conditions to loaders #31303

Conversation

jkrems commented Jan 10, 2020 • edited Loading

Checklist

jkrems commented Jan 10, 2020

guybedford commented Jan 11, 2020

jkrems commented Feb 10, 2020

guybedford left a comment

Choose a reason for hiding this comment

jkrems commented Mar 2, 2020

bmeck left a comment

Choose a reason for hiding this comment

This comment has been minimized.

This comment has been minimized.

guybedford left a comment

Choose a reason for hiding this comment

nodejs-github-bot commented Mar 29, 2020 • edited by addaleax Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

nodejs-github-bot commented Mar 31, 2020

jkrems commented Mar 31, 2020

addaleax commented Apr 2, 2020

nodejs-github-bot commented Apr 2, 2020

jkrems commented Apr 2, 2020 • edited Loading

nodejs-github-bot commented Apr 2, 2020

addaleax commented Apr 2, 2020

jkrems commented Jan 10, 2020 •

edited

Loading

nodejs-github-bot commented Mar 29, 2020 •

edited by addaleax

Loading

jkrems commented Apr 2, 2020 •

edited

Loading