Refactor Sleep into sleep.h

nodejs · Feb 9, 2018 · 8ec4423 · 8ec4423
1 parent 2678eaf
commit 8ec4423
Show file tree

Hide file tree

Showing 5 changed files with 20 additions and 8 deletions.
diff --git a/Makefile b/Makefile
@@ -71,6 +71,7 @@ LINT_SOURCES = \
 	test/cpp/returnvalue.cpp \
 	test/cpp/setcallhandler.cpp \
 	test/cpp/settemplate.cpp \
+	test/cpp/sleeph.h \
 	test/cpp/strings.cpp \
 	test/cpp/symbols.cpp \
 	test/cpp/threadlocal.cpp \

diff --git a/test/cpp/asyncresource.cpp b/test/cpp/asyncresource.cpp
@@ -7,7 +7,7 @@
  ********************************************************************/
 
 #include <nan.h>
-#include <unistd.h>
+#include "sleep.h"
 
 using namespace Nan;  // NOLINT(build/namespaces)
 
@@ -30,7 +30,7 @@ class DelayRequest : public AsyncResource {
 
 void Delay(uv_work_t* req) {
   DelayRequest *delay_request = static_cast<DelayRequest*>(req->data);
-  sleep(delay_request->milliseconds / 1000);
+  Sleep(delay_request->milliseconds);
 }
 
 void AfterDelay(uv_work_t* req, int status) {

diff --git a/test/cpp/asyncworker.cpp b/test/cpp/asyncworker.cpp
@@ -6,10 +6,7 @@
  * MIT License <https://github.com/nodejs/nan/blob/master/LICENSE.md>
  ********************************************************************/
 
-#ifndef _WIN32
-#include <unistd.h>
-#define Sleep(x) usleep((x)*1000)
-#endif
+#include "sleep.h"
 #include <nan.h>
 
 using namespace Nan;  // NOLINT(build/namespaces)

diff --git a/test/cpp/callbackcontext.cpp b/test/cpp/callbackcontext.cpp
@@ -7,7 +7,7 @@
  ********************************************************************/
 
 #include <nan.h>
-#include <unistd.h>
+#include "sleep.h"
 
 using namespace Nan;  // NOLINT(build/namespaces)
 
@@ -28,7 +28,7 @@ class DelayRequest : public AsyncResource {
 
 void Delay(uv_work_t* req) {
   DelayRequest *delay_request = static_cast<DelayRequest*>(req->data);
-  sleep(delay_request->milliseconds / 1000);
+  Sleep(delay_request->milliseconds);
 }
 
 void AfterDelay(uv_work_t* req, int status) {

diff --git a/test/cpp/sleep.h b/test/cpp/sleep.h
@@ -0,0 +1,14 @@
+/*********************************************************************
+ * NAN - Native Abstractions for Node.js
+ *
+ * Copyright (c) 2017 NAN contributors
+ *
+ * MIT License <https://github.com/nodejs/nan/blob/master/LICENSE.md>
+ ********************************************************************/
+
+#ifndef _WIN32
+#include <unistd.h>
+#define Sleep(x) usleep((x)*1000)
+#endif
+
+