Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New deprecation warnings in node 10.12 #810

Closed
jkrems opened this issue Oct 11, 2018 · 2 comments · Fixed by #825
Closed

New deprecation warnings in node 10.12 #810

jkrems opened this issue Oct 11, 2018 · 2 comments · Fixed by #825

Comments

@jkrems
Copy link

jkrems commented Oct 11, 2018

Some new deprecations have been introduced that may be worth addressing:

  • StringObject::New
  • non-Maybe ToString
  • WriteUtf8
jkrems pushed a commit to jkrems/nan that referenced this issue Oct 11, 2018
Fix deprecation warnings on node 10.12
44eaa1c 
node commit: nodejs/node@46c7d0d

Fixes nodejs#810
@jkrems jkrems mentioned this issue Oct 11, 2018
Closed
jkrems pushed a commit to jkrems/nan that referenced this issue Oct 11, 2018
Fix deprecation warnings on node 10.12
d63a550 
node commit: nodejs/node@46c7d0d

Fixes nodejs#810
@davedoesdev davedoesdev mentioned this issue Oct 19, 2018
Closed
@nolanmar511 nolanmar511 mentioned this issue Oct 23, 2018
Closed
@jhecking jhecking mentioned this issue Oct 31, 2018
Merged
3 tasks
@bnoordhuis bnoordhuis mentioned this issue Nov 13, 2018
Merged
@nolanmar511
Copy link
Contributor

So happy the deprecation warnings have been fixed!
Could a version nan with these fixes be released?

@kkoopa
Copy link
Collaborator

kkoopa commented Dec 10, 2018 via email

amitparida added a commit to amitparida/npm-nan that referenced this issue Oct 3, 2024
@amitparida
Fix Node.js v10.12.0 deprecation warnings.
ca9d241 
v10.12.0 turns on a number of V8 deprecation warnings. This commit fixes
them in NAN.

Fixes: nodejs/nan#810
PR-URL: nodejs/nan#825
Refs: nodejs/nan#811
Reviewed-By: Benjamin Byholm <bbyholm@abo.fi>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Node.js v10.12.0 deprecation warnings.
3 participants
@jkrems @kkoopa @nolanmar511