v8::StringObject::New(v8::Local<v8::String>&) is not available in latest v8-canary build

[nolanmar511]

I see the deprecation warnings are silenced where v8::StringObject::New(v8::Local<v8::String>&) is used (here). With the latest v8-canary release, this method is no longer available.

It would be awesome if it were possible to use nan in (some capacities) with v8-canary build!

[Flarna]

see #831

[kkoopa]

As mentioned in #831 it will not be merged quite yet, since more breaking changes might come, but if you check out that PR branch everything should work for now.

[nolanmar511]

How long would it be until #831 would be merged in?

It's hard for me to both depend on NAN and ensure that my module won't break with the next release of Node.js given that my module (or any module that includes "nan.h") depending on NAN can't be compile with Node.js master.

While downloading the code from a PR is possible, I'm not super comfortable with downloading code from a PR in a continuous integration test for several months.

[nolanmar511]

I should mention, the module I work on might be a bit weird. It uses v8's profiling tools, so we like have a continuous e2e test which uses the v8-canary build, to try to find any problems that might occur in the profilers we use sooner.

I know this use case isn't really supported by NAN, but it's definitely nice when it works.

[kkoopa]

I was planning on holding out until the release of Node 12 or just before. While I suppose there is no greater harm in merging it earlier, that would still require pulling the master branch in place of the #831 branch.

[kkoopa]

Alright, it is merged.

[nolanmar511]

Thanks!