Fix compilation on io.js 3 #728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
Thanks for reviewing. I will merge now. |
mkrufky
added a commit
to mkrufky/nan
that referenced
this pull request
Feb 23, 2018
mkrufky
added a commit
to mkrufky/nan
that referenced
this pull request
Feb 23, 2018
mkrufky
added a commit
to mkrufky/nan
that referenced
this pull request
Feb 23, 2018
mkrufky
added a commit
that referenced
this pull request
Feb 26, 2018
This adds a new file called `nan_define_own_property_helper.h` that contains a deduplicated code block taken from very similar code between `nan_maybe_43_inl.h` and `nan_maybe_pre_43_inl.h ` To anyone looking and scratching their head as to how the code block in `nan_maybe_43_inl.h` ever gets reached at all, this apparently happens in io.js 3 (see #725) As discussed: #728 (comment)
xzyfer
added a commit
to xzyfer/node-sass
that referenced
this pull request
Mar 10, 2018
I ran into [an issue][1] compiling the iojs 3 binary on OSX. This sound affect anyone in reality but just in case. [1]: nodejs/nan#728
xzyfer
added a commit
to sass/node-sass
that referenced
this pull request
Mar 10, 2018
I ran into [an issue][1] compiling the iojs 3 binary on OSX. This sound affect anyone in reality but just in case. [1]: nodejs/nan#728
amitparida
added a commit
to amitparida/npm-nan
that referenced
this pull request
Oct 3, 2024
This adds a new file called `nan_define_own_property_helper.h` that contains a deduplicated code block taken from very similar code between `nan_maybe_43_inl.h` and `nan_maybe_pre_43_inl.h ` To anyone looking and scratching their head as to how the code block in `nan_maybe_43_inl.h` ever gets reached at all, this apparently happens in io.js 3 (see #725) As discussed: nodejs/nan#728 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #725