Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add context awareness to Nan::AsyncWorker and Nan::Callback #731

Merged
merged 9 commits into from
Feb 13, 2018
Merged

Add context awareness to Nan::AsyncWorker and Nan::Callback #731

merged 9 commits into from
Feb 13, 2018

Commits on Feb 9, 2018

  1. Add context aware Nan::Callback::Call functions

    @ofrobots
    ofrobots committed Feb 9, 2018
    Configuration menu
    Copy the full SHA
    56c2821 View commit details
    Browse the repository at this point in the history

  2. Make AsyncWorker context aware

    @ofrobots
    ofrobots committed Feb 9, 2018
    Configuration menu
    Copy the full SHA
    dad30e8 View commit details
    Browse the repository at this point in the history

  3. Make AsyncResource non-{copy,assign,move}-able 

    Also some cleanup
* avoid unused private field warning on old node versions
* no reason to have async_context as a concept
* avoids camelCase for field asyncContext

less camel, less case
    @ofrobots
    ofrobots committed Feb 9, 2018
    Configuration menu
    Copy the full SHA
    2678eaf View commit details
    Browse the repository at this point in the history

  4. Refactor Sleep into sleep.h

    @ofrobots
    ofrobots committed Feb 9, 2018
    Configuration menu
    Copy the full SHA
    8ec4423 View commit details
    Browse the repository at this point in the history

  5. New Callback::Call functions should return MaybeLocal

    @ofrobots
    ofrobots committed Feb 9, 2018
    Configuration menu
    Copy the full SHA
    f150b27 View commit details
    Browse the repository at this point in the history

  6. fix compile problem with older node versions

    @ofrobots
    ofrobots committed Feb 9, 2018
    Configuration menu
    Copy the full SHA
    78712b1 View commit details
    Browse the repository at this point in the history

  7. fix typo in Makefile

    @ofrobots
    ofrobots committed Feb 9, 2018
    Configuration menu
    Copy the full SHA
    65e37fa View commit details
    Browse the repository at this point in the history

  8. make docs consistent with the api again

    @ofrobots
    ofrobots committed Feb 9, 2018
    Configuration menu
    Copy the full SHA
    881cb4c View commit details
    Browse the repository at this point in the history

  9. address code review comments

    @ofrobots
    ofrobots committed Feb 9, 2018
    Configuration menu
    Copy the full SHA
    36c3801 View commit details
    Browse the repository at this point in the history