Support Node 23 #979
Support Node 23 #979
Conversation
|
Turns out it is not that easy. First, a couple tests need updating. Second, the interceptors are not correctly handled in that they do require return values or will require them soon. I have some workarounds in mind, but implementing them will take a bit of effort. Addons will require a tiny bit of rewriting if using interceptors, but that is par for the course. |
It was removed ages ago, but never marked as deprecated.
|
Some tests are still failing related to the Holder change and interceptors. It might be that the tests simply need updating due to the functionality used not being allowed anymore. I do not have time to figure out what the deal is, so this will be stuck until someone clears it up. |
Use FunctionCallbackInfo::This instead. See http://crbug.com/333672197.
This requires minor changes in user code due to the need to call and return from Intercepted::No or Intercepted::Yes. While an operator conversion on classes would have been nicer, implicit conversion to void is not possible.
|
I believe I fixed the tests. Let us wait and see. |
|
@bnoordhuis Any chance you remember what the deal with |
|
+1 this. Ended up needing to manually patch to use Electron v33. |
|
It looks like this PR is stalled, I am using this workaround for my Electron 33 builds: #978 (comment). Works with any version of Electron supported by nan v2.22.0. |
|
@kkoopa seems to work with MagicMirror test suite (and others local test with some library) |
|
Any updates on this PR's status? |
|
pinging @kkoopa ? |
V8 Was bumped, this would be a patch release, since I already claimed support for Node 23 in 2.22.0.
Also fixes #978.