Problem with https://github.com/nodejs/node-addon-api/pull/874

[mhdawson]

Issue raised in closed PR - #874

Report is that PR breaks existing code:

From @ShenHongFei

This commit breaks the following code:

    void foo (const CallbackInfo& info) {
        const Object obj = info[0].As<Object>();
        obj["xxx"].As<Boolean>();
    }

because the following methods were deleted in this commit

    /// Gets or sets an indexed property or array element.
    PropertyLValue<Value> operator[](Value index  /// Property / element index
    ) const;

    /// Gets a named property.
    MaybeOrValue<Value> operator[](
        const char* utf8name  ///< UTF-8 encoded null-terminated property name
    ) const;

    /// Gets a named property.
    MaybeOrValue<Value> operator[](
        const std::string& utf8name  ///< UTF-8 encoded property name
    ) const;

    /// Gets an indexed property or array element.
    MaybeOrValue<Value> operator[](uint32_t index  ///< Property / element index
    ) const;

[mhdawson]

Looks to me that only these 3 were removed:

/// Gets a named property.
    MaybeOrValue<Value> operator[](
        const char* utf8name  ///< UTF-8 encoded null-terminated property name
    ) const;

    /// Gets a named property.
    MaybeOrValue<Value> operator[](
        const std::string& utf8name  ///< UTF-8 encoded property name
    ) const;

    /// Gets an indexed property or array element.
    MaybeOrValue<Value> operator[](uint32_t index  ///< Property / element index
    ) const;

[mhdawson]

Adding those back in results in these failures:

make: Entering directory '/home/midawson/newpull/node-addon-api/test/build'
  CXX(target) Release/obj.target/binding/addon.o
In file included from ../addon.cc:3:
../../napi.h:762:25: error: ‘Napi::MaybeOrValue<Napi::Value> Napi::Object::operator[](const char*) const’ cannot be overloaded with ‘Napi::Object::PropertyLValue<std::__cxx11::basic_string<char> > Napi::Object::operator[](const char*) const’
     MaybeOrValue<Value> operator[](
                         ^~~~~~~~
../../napi.h:743:33: note: previous declaration ‘Napi::Object::PropertyLValue<std::__cxx11::basic_string<char> > Napi::Object::operator[](const char*) const’
     PropertyLValue<std::string> operator[](
                                 ^~~~~~~~
../../napi.h:767:25: error: ‘Napi::MaybeOrValue<Napi::Value> Napi::Object::operator[](const string&) const’ cannot be overloaded with ‘Napi::Object::PropertyLValue<std::__cxx11::basic_string<char> > Napi::Object::operator[](const string&) const’
     MaybeOrValue<Value> operator[](
                         ^~~~~~~~
../../napi.h:748:33: note: previous declaration ‘Napi::Object::PropertyLValue<std::__cxx11::basic_string<char> > Napi::Object::operator[](const string&) const’
     PropertyLValue<std::string> operator[](
                                 ^~~~~~~~
../../napi.h:772:25: error: ‘Napi::MaybeOrValue<Napi::Value> Napi::Object::operator[](uint32_t) const’ cannot be overloaded with ‘Napi::Object::PropertyLValue<unsigned int> Napi::Object::operator[](uint32_t) const’
     MaybeOrValue<Value> operator[](uint32_t index  ///< Property / element index
                         ^~~~~~~~
../../napi.h:753:30: note: previous declaration ‘Napi::Object::PropertyLValue<unsigned int> Napi::Object::operator[](uint32_t) const’
     PropertyLValue<uint32_t> operator[](
                            ^~~~~~~~

[mhdawson]

Submitted a PR to revert just the parts that caused the regression along with updates to the tests that fail to compoile without the fix/pass with it.