[Docs] undocumented method(s) on Object. #614

zander · 2019-11-30T19:02:10Z

Looking at https://github.com/nodejs/node-addon-api/blob/master/doc/object.md

I failed to find a way to iterate over properties. I eventually found it via the napi docs and the addon implementation files.

Would be nice if the docs can be complete.

Napi::Object::GetPropertyNames() is not listed in the API docs.

Napi::Object::HasOwnProperty() is not listed in the API docs.

Napi::Object::Delete() is not listed in the API docs.

Fixes: nodejs#614

Fixes: #614 PR-URL: #615 Fixes: #614 Reviewed-By: NickNaso <nicoladelgobbo@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

Fixes: nodejs/node-addon-api#614 PR-URL: nodejs/node-addon-api#615 Fixes: nodejs/node-addon-api#614 Reviewed-By: NickNaso <nicoladelgobbo@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

tniessen added a commit to tniessen/node-addon-api that referenced this issue Nov 30, 2019

Add GetPropertyNames, HasOwnProperty, Delete

026d3d0

Fixes: nodejs#614

tniessen added a commit to tniessen/node-addon-api that referenced this issue Nov 30, 2019

Add GetPropertyNames, HasOwnProperty, Delete

e369a10

Fixes: nodejs#614

tniessen mentioned this issue Nov 30, 2019

Add GetPropertyNames, HasOwnProperty, Delete #615

Merged

mhdawson closed this as completed in #615 Dec 5, 2019

mhdawson pushed a commit that referenced this issue Dec 5, 2019

Add GetPropertyNames, HasOwnProperty, Delete (#615)

c584343

Fixes: #614 PR-URL: #615 Fixes: #614 Reviewed-By: NickNaso <nicoladelgobbo@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Docs] undocumented method(s) on Object. #614

[Docs] undocumented method(s) on Object. #614

zander commented Nov 30, 2019

[Docs] undocumented method(s) on Object. #614

[Docs] undocumented method(s) on Object. #614

Comments

zander commented Nov 30, 2019