Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do we need doc/working_with_javascript_values.md? #797

Closed
gabrielschulhof opened this issue Aug 25, 2020 · 2 comments · Fixed by #815
Closed

Do we need doc/working_with_javascript_values.md? #797

gabrielschulhof opened this issue Aug 25, 2020 · 2 comments · Fixed by #815

Comments

@gabrielschulhof
Copy link
Contributor

This file is referenced from README.md and consists of a small blurb and of links to a few classes:

doc/working_with_javascript_values.md
@gabrielschulhof
Copy link
Contributor Author

At the very least it seems incomplete. It documents that node-addon-api provides some classes that help with manipulating JS values, and then lists some classes. Yet we have many more classes that help with manipulating JS values than that, and they are amply documented.

@mhdawson
Copy link
Member

From discussion in the N-API team meeting today with #798, it seems like it well covered so this can be removed.

gabrielschulhof pushed a commit to gabrielschulhof/node-addon-api that referenced this issue Sep 16, 2020
doc: remove a file
bcb0447 
Remove doc/working_with_javascript_values.md because it was a stub and
the matter is covered elsewhere.

Fixes: nodejs#797
@gabrielschulhof gabrielschulhof mentioned this issue Sep 16, 2020
Merged
mhdawson pushed a commit that referenced this issue Sep 17, 2020
@gabrielschulhof
doc: remove a file (#815)
51e25f7 
Remove doc/working_with_javascript_values.md because it was a stub and
the matter is covered elsewhere.

Fixes: #797
Superlokkus pushed a commit to Superlokkus/node-addon-api that referenced this issue Nov 20, 2020
@gabrielschulhof @Superlokkus
doc: remove a file (nodejs#815)
27a12b3 
Remove doc/working_with_javascript_values.md because it was a stub and
the matter is covered elsewhere.

Fixes: nodejs#797
kevindavies8 added a commit to kevindavies8/node-addon-api-Develop that referenced this issue Aug 24, 2022
@kevindavies8
doc: remove a file (#815)
a0f4cbe 
Remove doc/working_with_javascript_values.md because it was a stub and
the matter is covered elsewhere.

Fixes: nodejs/node-addon-api#797
Marlyfleitas added a commit to Marlyfleitas/node-api-addon-Development that referenced this issue Aug 26, 2022
@Marlyfleitas
doc: remove a file (#815)
08f10b3 
Remove doc/working_with_javascript_values.md because it was a stub and
the matter is covered elsewhere.

Fixes: nodejs/node-addon-api#797
wroy7860 added a commit to wroy7860/addon-api-benchmark-node that referenced this issue Sep 19, 2022
@wroy7860
doc: remove a file (#815)
e667ba3 
Remove doc/working_with_javascript_values.md because it was a stub and
the matter is covered elsewhere.

Fixes: nodejs/node-addon-api#797
johnfrench3 pushed a commit to johnfrench3/node-addon-api-git that referenced this issue Aug 11, 2023
doc: remove a file (#815)
6d39145 
Remove doc/working_with_javascript_values.md because it was a stub and
the matter is covered elsewhere.

Fixes: nodejs/node-addon-api#797
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

doc: remove a file gabrielschulhof/node-addon-api
2 participants
@gabrielschulhof @mhdawson