Adding unit tests for FunctionReference class #1035
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nodejs/node-api anybody else want to take a look before I land this? |
KevinEady
reviewed
Sep 3, 2021
test/functionreference.js
Outdated
| let hook; | ||
| const events = [] | ||
| return new Promise((res, reject) =>{ | ||
| console.log('Installing async hook') |
JckXia
force-pushed
the
add-tests-to-function-ref
branch
from
4986dce
to
c0396b3
Compare
test/binding.gyp
Outdated
| @@ -27,6 +27,7 @@ | |||
| 'error.cc', | |||
| 'external.cc', | |||
| 'function.cc', | |||
| 'funcRefObject.cc', | |||
There was a problem hiding this comment.
Please make sure the file names and the name of the init function are consistent for #1078 by @deepakrkris!
There was a problem hiding this comment.
@deepakrkris this is interesting, because it creates a situation where a test file has a dependency. Maybe this class definition should go to the top of function_reference.cc instead because that's the only file using it. Then we can also avoid having to deal with file dependencies.
test/funcRefObject.h
Outdated
| int _value; | ||
| }; | ||
|
|
||
| #endif |
test/function_reference.cc
Outdated
| Napi::FunctionReference ref; | ||
| ref.Reset(info[0].As<Function>()); | ||
|
|
||
| Napi::AsyncContext contxt(info.Env(), "func_ref_resources", {}); |
test/function_reference.cc
Outdated
| args[argIdx] = info[i]; | ||
| } | ||
|
|
||
| Napi::AsyncContext contxt(info.Env(), "func_ref_resources", {}); |
test/function_reference.cc
Outdated
| exports["call"] = Function::New(env, Call); | ||
| exports["construct"] = Function::New(env, Construct); | ||
|
|
||
| return exports; | ||
| } | ||
| } |
There was a problem hiding this comment.
Please add a newline!
test/function_reference.js
Outdated
| binding.AsyncCallWithArgv(testFuncB, 2, 4, 5, 6) === testFuncB(2, 4, 5, 6) | ||
| ); | ||
| } | ||
| function test (binding) { |
There was a problem hiding this comment.
This should be async because it should await canCallAsyncFunctionWithDifferentOverloads.
There was a problem hiding this comment.
... and it should itself be awaited at the call site.
JckXia
force-pushed
the
add-tests-to-function-ref
branch
from
c0396b3
to
5eb3c5e
Compare
mhdawson
pushed a commit
that referenced
this pull request
Oct 25, 2021
PR-URL: #1035 Reviewed-By: Michael Dawson <midawson@redhat.com Reviewed-By: Kevin Eady <kevin.c.eady@gmail.com>
|
Landed as 04b26a9 |
kevindavies8
added a commit
to kevindavies8/node-addon-api-Develop
that referenced
this pull request
Aug 24, 2022
PR-URL: nodejs/node-addon-api#1035 Reviewed-By: Michael Dawson <midawson@redhat.com Reviewed-By: Kevin Eady <kevin.c.eady@gmail.com>
Marlyfleitas
added a commit
to Marlyfleitas/node-api-addon-Development
that referenced
this pull request
Aug 26, 2022
PR-URL: nodejs/node-addon-api#1035 Reviewed-By: Michael Dawson <midawson@redhat.com Reviewed-By: Kevin Eady <kevin.c.eady@gmail.com>
wroy7860
added a commit
to wroy7860/addon-api-benchmark-node
that referenced
this pull request
Sep 19, 2022
PR-URL: nodejs/node-addon-api#1035 Reviewed-By: Michael Dawson <midawson@redhat.com Reviewed-By: Kevin Eady <kevin.c.eady@gmail.com>
johnfrench3
pushed a commit
to johnfrench3/node-addon-api-git
that referenced
this pull request
Aug 11, 2023
PR-URL: nodejs/node-addon-api#1035 Reviewed-By: Michael Dawson <midawson@redhat.com Reviewed-By: Kevin Eady <kevin.c.eady@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding test coverage for FunctionReference class. #989