Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardize unit test file names #1056

Closed
wants to merge 1 commit into from
Closed

Standardize unit test file names #1056

wants to merge 1 commit into from

Conversation

deepakrkris
Copy link
Contributor

No description provided.

@deepakrkris deepakrkris mentioned this pull request Aug 27, 2021
Closed
mhdawson
mhdawson approved these changes Aug 27, 2021
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once commit comment is updated to indicates that all non file-renames are due to fixes issues reported by linter when file was renamed.

NickNaso
NickNaso approved these changes Sep 2, 2021
View reviewed changes
Copy link
Member

@NickNaso NickNaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Could you please add little description about what this PR do. This could help us in the future.

@mhdawson
Copy link
Member

mhdawson commented Sep 3, 2021

@deepakrkris just waiting for the updates to the comments before landing.

Standardize unit test file names
733d91a 
- change all unit test file names to snake case
  this helps in parsing file names to tokens and infer metadata
  like export initializers

- all other changes other than file names is due to linter errors
@deepakrkris
Copy link
Contributor Author

@mhdawson @NickNaso @gabrielschulhof @KevinEady,
I have included a detailed commit message about the changes and linter fixes.

@mhdawson
Copy link
Member

mhdawson commented Sep 9, 2021

@deepakrkris thanks, landing now

mhdawson pushed a commit that referenced this pull request Sep 9, 2021
@mhdawson
test: standardize unit test file names
cbac3aa 
- change all unit test file names to snake case
  this helps in parsing file names to tokens and infer metadata
  like export initializers

- all other changes other than file names is due to linter errors

PR-URL: #1056
Reviewed-By: Michael Dawson <midawson@redhat.com
Reviewed-By: NickNaso <nicoladelgobbo@gmail.com>
@mhdawson
Copy link
Member

mhdawson commented Sep 9, 2021

Landed as cbac3aa

@mhdawson mhdawson closed this Sep 9, 2021
deepakrkris pushed a commit to deepakrkris/node-addon-api that referenced this pull request Sep 23, 2021
test: standardize unit test file names
88ef504 
- change all unit test file names to snake case
  this helps in parsing file names to tokens and infer metadata
  like export initializers

- all other changes other than file names is due to linter errors

PR-URL: nodejs#1056
Reviewed-By: Michael Dawson <midawson@redhat.com
Reviewed-By: NickNaso <nicoladelgobbo@gmail.com>
deepakrkris pushed a commit to deepakrkris/node-addon-api that referenced this pull request Oct 15, 2021
test: standardize unit test file names
930b783 
- change all unit test file names to snake case
  this helps in parsing file names to tokens and infer metadata
  like export initializers

- all other changes other than file names is due to linter errors

PR-URL: nodejs#1056
Reviewed-By: Michael Dawson <midawson@redhat.com
Reviewed-By: NickNaso <nicoladelgobbo@gmail.com>
kevindavies8 added a commit to kevindavies8/node-addon-api-Develop that referenced this pull request Aug 24, 2022
@kevindavies8
test: standardize unit test file names
f887486 
- change all unit test file names to snake case
  this helps in parsing file names to tokens and infer metadata
  like export initializers

- all other changes other than file names is due to linter errors

PR-URL: nodejs/node-addon-api#1056
Reviewed-By: Michael Dawson <midawson@redhat.com
Reviewed-By: NickNaso <nicoladelgobbo@gmail.com>
Marlyfleitas added a commit to Marlyfleitas/node-api-addon-Development that referenced this pull request Aug 26, 2022
@Marlyfleitas
test: standardize unit test file names
510667c 
- change all unit test file names to snake case
  this helps in parsing file names to tokens and infer metadata
  like export initializers

- all other changes other than file names is due to linter errors

PR-URL: nodejs/node-addon-api#1056
Reviewed-By: Michael Dawson <midawson@redhat.com
Reviewed-By: NickNaso <nicoladelgobbo@gmail.com>
wroy7860 added a commit to wroy7860/addon-api-benchmark-node that referenced this pull request Sep 19, 2022
@wroy7860
test: standardize unit test file names
b80fb22 
- change all unit test file names to snake case
  this helps in parsing file names to tokens and infer metadata
  like export initializers

- all other changes other than file names is due to linter errors

PR-URL: nodejs/node-addon-api#1056
Reviewed-By: Michael Dawson <midawson@redhat.com
Reviewed-By: NickNaso <nicoladelgobbo@gmail.com>
johnfrench3 pushed a commit to johnfrench3/node-addon-api-git that referenced this pull request Aug 11, 2023
test: standardize unit test file names
3019b11 
- change all unit test file names to snake case
  this helps in parsing file names to tokens and infer metadata
  like export initializers

- all other changes other than file names is due to linter errors

PR-URL: nodejs/node-addon-api#1056
Reviewed-By: Michael Dawson <midawson@redhat.com
Reviewed-By: NickNaso <nicoladelgobbo@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhdawson mhdawson mhdawson approved these changes

@NickNaso NickNaso NickNaso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@deepakrkris @mhdawson @NickNaso