src: fix casts to not be undefined behavior #1070
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I guess if these were broken in practice, V8/Node.js itself would also experience difficulties with it, but there’s no real reason not to use the proper alternatives.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
mhdawson
pushed a commit
that referenced
this pull request
Sep 16, 2021
I guess if these were broken in practice, V8/Node.js itself would also experience difficulties with it, but there’s no real reason not to use the proper alternatives. PR-URL: #1070 Reviewed-By: Michael Dawson <midawson@redhat.com>
deepakrkris
pushed a commit
to deepakrkris/node-addon-api
that referenced
this pull request
Sep 23, 2021
I guess if these were broken in practice, V8/Node.js itself would also experience difficulties with it, but there’s no real reason not to use the proper alternatives. PR-URL: nodejs#1070 Reviewed-By: Michael Dawson <midawson@redhat.com>
deepakrkris
pushed a commit
to deepakrkris/node-addon-api
that referenced
this pull request
Oct 15, 2021
I guess if these were broken in practice, V8/Node.js itself would also experience difficulties with it, but there’s no real reason not to use the proper alternatives. PR-URL: nodejs#1070 Reviewed-By: Michael Dawson <midawson@redhat.com>
kevindavies8
added a commit
to kevindavies8/node-addon-api-Develop
that referenced
this pull request
Aug 24, 2022
I guess if these were broken in practice, V8/Node.js itself would also experience difficulties with it, but there’s no real reason not to use the proper alternatives. PR-URL: nodejs/node-addon-api#1070 Reviewed-By: Michael Dawson <midawson@redhat.com>
Marlyfleitas
added a commit
to Marlyfleitas/node-api-addon-Development
that referenced
this pull request
Aug 26, 2022
I guess if these were broken in practice, V8/Node.js itself would also experience difficulties with it, but there’s no real reason not to use the proper alternatives. PR-URL: nodejs/node-addon-api#1070 Reviewed-By: Michael Dawson <midawson@redhat.com>
wroy7860
added a commit
to wroy7860/addon-api-benchmark-node
that referenced
this pull request
Sep 19, 2022
I guess if these were broken in practice, V8/Node.js itself would also experience difficulties with it, but there’s no real reason not to use the proper alternatives. PR-URL: nodejs/node-addon-api#1070 Reviewed-By: Michael Dawson <midawson@redhat.com>
johnfrench3
pushed a commit
to johnfrench3/node-addon-api-git
that referenced
this pull request
Aug 11, 2023
I guess if these were broken in practice, V8/Node.js itself would also experience difficulties with it, but there’s no real reason not to use the proper alternatives. PR-URL: nodejs/node-addon-api#1070 Reviewed-By: Michael Dawson <midawson@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I guess if these were broken in practice, V8/Node.js itself would also
experience difficulties with it, but there’s no real reason not to use
the proper alternatives.