-
Notifications
You must be signed in to change notification settings - Fork 462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
src: add Object::TypeTag, Object::CheckTypeTag #1261
Conversation
Looks like the test has different outcomes depending on Node version, which I can reproduce locally. The test (cpp, js) is similar to the one found in node core (cpp, js). It looks like there was an issue in type tag checking nodejs/node#43786 fixed by nodejs/node#43788 ... Was this backported to other Node versions? EDIT: I just changed the test to not use the bugged checks if node version < 18. v14: Failure ❌
v16: Failure ❌
v18: Success ✅
v19: Success ✅
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR-URL: #1261 Reviewed-By: Michael Dawson <midawson@redhat.com
Landed as b11e4de |
PR-URL: nodejs/node-addon-api#1261 Reviewed-By: Michael Dawson <midawson@redhat.com
Adds support for
napi_type_tag_object
viaObject::TypeTag
andnapi_check_object_type_tag
viaObject::CheckTypeTag
.Closes: #1260