Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix MSVC warning C4244 in tests #236

Closed
wants to merge 1 commit into from
Closed

test: fix MSVC warning C4244 in tests #236

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion test/basic_types/number.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,8 @@ Value ToUint32(const CallbackInfo& info) {
}

Value ToInt64(const CallbackInfo& info) {
return Number::New(info.Env(), info[0].As<Number>().Int64Value());
return Number::New(info.Env(),
static_cast<double>(info[0].As<Number>().Int64Value()));
}

Value ToFloat(const CallbackInfo& info) {
Expand Down
6 changes: 4 additions & 2 deletions test/dataview/dataview.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,13 @@ static Value GetArrayBuffer(const CallbackInfo& info) {
}

static Value GetByteOffset(const CallbackInfo& info) {
return Number::New(info.Env(), info[0].As<DataView>().ByteOffset());
return Number::New(info.Env(),
static_cast<double>(info[0].As<DataView>().ByteOffset()));
}

static Value GetByteLength(const CallbackInfo& info) {
return Number::New(info.Env(), info[0].As<DataView>().ByteLength());
return Number::New(info.Env(),
static_cast<double>(info[0].As<DataView>().ByteLength()));
}

Object InitDataView(Env env) {
Expand Down