Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: refer to TypedArray and ArrayBuffer from Array #465

Conversation

gabrielschulhof
Copy link
Contributor

Add a blurb to the Napi::Array documentation that refers readers to
Napi::TypedArray and Napi::ArrayBuffer for using arrays with large
amounts of data.

Copy link
Member

@NickNaso NickNaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just little changes

doc/basic_types.md Show resolved Hide resolved
Add a blurb to the `Napi::Array` documentation that refers readers to
`Napi::TypedArray` and `Napi::ArrayBuffer` for using arrays with large
amounts of data.
@gabrielschulhof gabrielschulhof force-pushed the refer-to-arraybuffer-and-typed-array-from-array branch from 54db4ae to 5770392 Compare April 3, 2019 05:13
@gabrielschulhof
Copy link
Contributor Author

@NickNaso fixed.

@NickNaso NickNaso mentioned this pull request Apr 3, 2019
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson mhdawson merged commit 36863f0 into nodejs:master Apr 4, 2019
@mhdawson
Copy link
Member

mhdawson commented Apr 4, 2019

Landed as 36863f0

@gabrielschulhof gabrielschulhof deleted the refer-to-arraybuffer-and-typed-array-from-array branch December 17, 2019 01:36
kevindavies8 added a commit to kevindavies8/node-addon-api-Develop that referenced this pull request Aug 24, 2022
Add a blurb to the `Napi::Array` documentation that refers readers to
`Napi::TypedArray` and `Napi::ArrayBuffer` for using arrays with large
amounts of data.

PR-URL: nodejs/node-addon-api#465
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
 Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@NickNaso.local>
Marlyfleitas added a commit to Marlyfleitas/node-api-addon-Development that referenced this pull request Aug 26, 2022
Add a blurb to the `Napi::Array` documentation that refers readers to
`Napi::TypedArray` and `Napi::ArrayBuffer` for using arrays with large
amounts of data.

PR-URL: nodejs/node-addon-api#465
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
 Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@NickNaso.local>
wroy7860 added a commit to wroy7860/addon-api-benchmark-node that referenced this pull request Sep 19, 2022
Add a blurb to the `Napi::Array` documentation that refers readers to
`Napi::TypedArray` and `Napi::ArrayBuffer` for using arrays with large
amounts of data.

PR-URL: nodejs/node-addon-api#465
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
 Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@NickNaso.local>
johnfrench3 pushed a commit to johnfrench3/node-addon-api-git that referenced this pull request Aug 11, 2023
Add a blurb to the `Napi::Array` documentation that refers readers to
`Napi::TypedArray` and `Napi::ArrayBuffer` for using arrays with large
amounts of data.

PR-URL: nodejs/node-addon-api#465
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
 Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@NickNaso.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants