macros: create errors fully namespaced #506
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Errors in `NAPI_THROW()` and Co. were being thrown as `Error:New(...)` but they should be thrown as `Napi::Error::New(...)` because the former assumes that the user has opted to declare `using namespace Napi;`.
devsnek
approved these changes
Jun 28, 2019
gabrielschulhof
pushed a commit
that referenced
this pull request
Jul 10, 2019
Errors in `NAPI_THROW()` and Co. were being thrown as `Error:New(...)` but they should be thrown as `Napi::Error::New(...)` because the former assumes that the user has opted to declare `using namespace Napi;`. PR-URL: #506 Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
|
Landed in c32d7db. |
kevindavies8
added a commit
to kevindavies8/node-addon-api-Develop
that referenced
this pull request
Aug 24, 2022
Errors in `NAPI_THROW()` and Co. were being thrown as `Error:New(...)` but they should be thrown as `Napi::Error::New(...)` because the former assumes that the user has opted to declare `using namespace Napi;`. PR-URL: nodejs/node-addon-api#506 Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Marlyfleitas
added a commit
to Marlyfleitas/node-api-addon-Development
that referenced
this pull request
Aug 26, 2022
Errors in `NAPI_THROW()` and Co. were being thrown as `Error:New(...)` but they should be thrown as `Napi::Error::New(...)` because the former assumes that the user has opted to declare `using namespace Napi;`. PR-URL: nodejs/node-addon-api#506 Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
wroy7860
added a commit
to wroy7860/addon-api-benchmark-node
that referenced
this pull request
Sep 19, 2022
Errors in `NAPI_THROW()` and Co. were being thrown as `Error:New(...)` but they should be thrown as `Napi::Error::New(...)` because the former assumes that the user has opted to declare `using namespace Napi;`. PR-URL: nodejs/node-addon-api#506 Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
johnfrench3
pushed a commit
to johnfrench3/node-addon-api-git
that referenced
this pull request
Aug 11, 2023
Errors in `NAPI_THROW()` and Co. were being thrown as `Error:New(...)` but they should be thrown as `Napi::Error::New(...)` because the former assumes that the user has opted to declare `using namespace Napi;`. PR-URL: nodejs/node-addon-api#506 Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Errors in
NAPI_THROW()and Co. were being thrown asError:New(...)but they should be thrown as
Napi::Error::New(...)because the formerassumes that the user has opted to declare
using namespace Napi;.