error: remove unnecessary if condition #562
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`NAPI_FATAL_IF_FAILED` would not return if the status is not `napi_ok`.
gabrielschulhof
approved these changes
Oct 10, 2019
|
Hmmm ... looks like it's unable to fetch the nightly release for Node.js v13.x. |
|
AIX nightly build archives have been missing since Oct 11th. Update: back online https://nodejs.org/download/nightly/v13.0.0-nightly20191018c8df5cf74a/ |
gabrielschulhof
pushed a commit
that referenced
this pull request
Oct 21, 2019
`NAPI_FATAL_IF_FAILED` would not return if the status is not `napi_ok`. PR-URL: #562 Reviewed-By: NickNaso <nicoladelgobbo@gmail.com> Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
|
Landed in 2e1769e. |
kevindavies8
added a commit
to kevindavies8/node-addon-api-Develop
that referenced
this pull request
Aug 24, 2022
`NAPI_FATAL_IF_FAILED` would not return if the status is not `napi_ok`. PR-URL: nodejs/node-addon-api#562 Reviewed-By: NickNaso <nicoladelgobbo@gmail.com> Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Marlyfleitas
added a commit
to Marlyfleitas/node-api-addon-Development
that referenced
this pull request
Aug 26, 2022
`NAPI_FATAL_IF_FAILED` would not return if the status is not `napi_ok`. PR-URL: nodejs/node-addon-api#562 Reviewed-By: NickNaso <nicoladelgobbo@gmail.com> Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
wroy7860
added a commit
to wroy7860/addon-api-benchmark-node
that referenced
this pull request
Sep 19, 2022
`NAPI_FATAL_IF_FAILED` would not return if the status is not `napi_ok`. PR-URL: nodejs/node-addon-api#562 Reviewed-By: NickNaso <nicoladelgobbo@gmail.com> Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
johnfrench3
pushed a commit
to johnfrench3/node-addon-api-git
that referenced
this pull request
Aug 11, 2023
`NAPI_FATAL_IF_FAILED` would not return if the status is not `napi_ok`. PR-URL: nodejs/node-addon-api#562 Reviewed-By: NickNaso <nicoladelgobbo@gmail.com> Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NAPI_FATAL_IF_FAILEDwould not return if the status is notnapi_ok.