Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix example code in doc/class_property_descriptor #587

Merged
merged 1 commit into from
Nov 13, 2019

Conversation

timrach
Copy link
Contributor

@timrach timrach commented Nov 5, 2019

Return type should be void and second function argument of type Napi::Value should be present.
See typedef:

typedef void (T::*InstanceSetterCallback)(const CallbackInfo& info, const Napi::Value& value);

Return type should be void and second function argument of type Napi::Value should be present.
See typedef: https://github.com/nodejs/node-addon-api/blob/295e560f5554c87d0a9dde6b73942ebd85fddb9d/napi.h#L1623
@timrach timrach changed the title Fix return type and declaration of setter callback Fix example code in doc/class_property_descriptor Nov 5, 2019
Copy link
Member

@NickNaso NickNaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NickNaso NickNaso mentioned this pull request Nov 5, 2019
15 tasks
@KevinEady KevinEady self-requested a review November 5, 2019 17:07
Copy link
Contributor

@KevinEady KevinEady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NickNaso NickNaso merged commit aa79e37 into nodejs:master Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants