Issue 602: Add template methods to ObjectWrap #604
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ObjectWrap<T> was enhanced to support template methods for
defining properties and methods of JS class. Now C++ methods and
functions may be passed as template parameters for
ObjectWrap<T>::InstanceMethod, ObjectWrap<T>::StaticAccessor, etc.
There are several benefits:
- no need to allocate extra memory for passing C++ function
napi callback and use add_finalizer() to free memory;
- a compiler can see whole chain of calls up to napi callback
that may allow better optimisation.
Some examples:
```cpp
// Method
InstanceMethod<&MyClass::method>("method");
// Read-write property
InstanceAccessor<&MyClass::get, &MyClass::set>("rw_prop");
// Read-only property
InstanceAccessor<&MyClass::get>("ro_prop");
```
Closes #602.
|
We should consider moving the existing methods to
@nodejs/n-api what do y'all think? |
|
IMO there are no really breaking changes landed on most recent major version v2. I'd prefer the latter less aggressive pattern for the common usage on |
|
I'm good with the move to napi-inl.deprecated.h, removing completely we can discuss later. We talked about adding a new deprecation guard so that people who already have napi_deprecated are not affected, but people can opt-in to the the higher level of deprecation. In this case we'll use: napi_disable_deprecated_1 napi_disable_deprecated will map to napi_disabled_deprecated_0 |
|
@mhdawson I think it would OK to land this PR as is, and then leave the move to deprecated to another PR. |
|
CI against v8.x: https://ci.nodejs.org/job/node-test-node-addon-api-new/1217/ |
|
Here it is again: CI against v8.x: https://ci.nodejs.org/job/node-test-node-addon-api-new/1218/ |
legendecas
approved these changes
Dec 5, 2019
gabrielschulhof
pushed a commit
that referenced
this pull request
Dec 5, 2019
ObjectWrap<T> was enhanced to support template methods for
defining properties and methods of JS class. Now C++ methods and
functions may be passed as template parameters for
ObjectWrap<T>::InstanceMethod, ObjectWrap<T>::StaticAccessor, etc.
There are several benefits:
- no need to allocate extra memory for passing C++ function
napi callback and use add_finalizer() to free memory;
- a compiler can see whole chain of calls up to napi callback
that may allow better optimisation.
Some examples:
```cpp
// Method
InstanceMethod<&MyClass::method>("method");
// Read-write property
InstanceAccessor<&MyClass::get, &MyClass::set>("rw_prop");
// Read-only property
InstanceAccessor<&MyClass::get>("ro_prop");
```
Fixes: #602
PR-URL: #604
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
|
Landed in ce91e14. |
kevindavies8
added a commit
to kevindavies8/node-addon-api-Develop
that referenced
this pull request
Aug 24, 2022
ObjectWrap<T> was enhanced to support template methods for
defining properties and methods of JS class. Now C++ methods and
functions may be passed as template parameters for
ObjectWrap<T>::InstanceMethod, ObjectWrap<T>::StaticAccessor, etc.
There are several benefits:
- no need to allocate extra memory for passing C++ function
napi callback and use add_finalizer() to free memory;
- a compiler can see whole chain of calls up to napi callback
that may allow better optimisation.
Some examples:
```cpp
// Method
InstanceMethod<&MyClass::method>("method");
// Read-write property
InstanceAccessor<&MyClass::get, &MyClass::set>("rw_prop");
// Read-only property
InstanceAccessor<&MyClass::get>("ro_prop");
```
Fixes: nodejs/node-addon-api#602
PR-URL: nodejs/node-addon-api#604
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Marlyfleitas
added a commit
to Marlyfleitas/node-api-addon-Development
that referenced
this pull request
Aug 26, 2022
ObjectWrap<T> was enhanced to support template methods for
defining properties and methods of JS class. Now C++ methods and
functions may be passed as template parameters for
ObjectWrap<T>::InstanceMethod, ObjectWrap<T>::StaticAccessor, etc.
There are several benefits:
- no need to allocate extra memory for passing C++ function
napi callback and use add_finalizer() to free memory;
- a compiler can see whole chain of calls up to napi callback
that may allow better optimisation.
Some examples:
```cpp
// Method
InstanceMethod<&MyClass::method>("method");
// Read-write property
InstanceAccessor<&MyClass::get, &MyClass::set>("rw_prop");
// Read-only property
InstanceAccessor<&MyClass::get>("ro_prop");
```
Fixes: nodejs/node-addon-api#602
PR-URL: nodejs/node-addon-api#604
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
wroy7860
added a commit
to wroy7860/addon-api-benchmark-node
that referenced
this pull request
Sep 19, 2022
ObjectWrap<T> was enhanced to support template methods for
defining properties and methods of JS class. Now C++ methods and
functions may be passed as template parameters for
ObjectWrap<T>::InstanceMethod, ObjectWrap<T>::StaticAccessor, etc.
There are several benefits:
- no need to allocate extra memory for passing C++ function
napi callback and use add_finalizer() to free memory;
- a compiler can see whole chain of calls up to napi callback
that may allow better optimisation.
Some examples:
```cpp
// Method
InstanceMethod<&MyClass::method>("method");
// Read-write property
InstanceAccessor<&MyClass::get, &MyClass::set>("rw_prop");
// Read-only property
InstanceAccessor<&MyClass::get>("ro_prop");
```
Fixes: nodejs/node-addon-api#602
PR-URL: nodejs/node-addon-api#604
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
johnfrench3
pushed a commit
to johnfrench3/node-addon-api-git
that referenced
this pull request
Aug 11, 2023
ObjectWrap<T> was enhanced to support template methods for
defining properties and methods of JS class. Now C++ methods and
functions may be passed as template parameters for
ObjectWrap<T>::InstanceMethod, ObjectWrap<T>::StaticAccessor, etc.
There are several benefits:
- no need to allocate extra memory for passing C++ function
napi callback and use add_finalizer() to free memory;
- a compiler can see whole chain of calls up to napi callback
that may allow better optimisation.
Some examples:
```cpp
// Method
InstanceMethod<&MyClass::method>("method");
// Read-write property
InstanceAccessor<&MyClass::get, &MyClass::set>("rw_prop");
// Read-only property
InstanceAccessor<&MyClass::get>("ro_prop");
```
Fixes: nodejs/node-addon-api#602
PR-URL: nodejs/node-addon-api#604
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ObjectWrap was enhanced to support template methods for
defining properties and methods of JS class. Now C++ methods and
functions may be passed as template parameters for
ObjectWrap::InstanceMethod, ObjectWrap::StaticAccessor, etc.
There are several benefits:
napi callback and use add_finalizer() to free memory;
that may allow better optimisation.
Some examples:
Closes #602.
Use squash method.