Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add test for own properties on ObjectWrap #645

Closed
wants to merge 2 commits into from
Closed

add test for own properties on ObjectWrap #645

wants to merge 2 commits into from

Conversation

gms1
Copy link
Contributor

@gms1 gms1 commented Jan 6, 2020 •
edited
Loading

fixes #644

@gms1 gms1 changed the title #644 add test for own properties on ObjectWrap add test for own properties on ObjectWrap Jan 6, 2020
gms1
gms1 commented Jan 6, 2020
View reviewed changes
test/objectwrap.cc
Napi::PropertyDescriptor::Accessor(info.Env(),
info.This().As<Napi::Object>(),
"ownProperty",
OwnPropertyGetter,
Copy link
Contributor Author

@gms1 gms1 Jan 6, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

worth considering:

-                                           OwnPropertyGetter,
-                                           napi_enumerable, this));
+                                           std::bind(&Test::Getter, this, std::placeholders::_1),
+                                           napi_enumerable));

mhdawson
mhdawson approved these changes Jan 6, 2020
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gabrielschulhof gabrielschulhof mentioned this pull request Jan 7, 2020
Closed
legendecas
legendecas approved these changes Jan 7, 2020
View reviewed changes
test/objectwrap.js Outdated Show resolved Hide resolved
@mhdawson
Copy link
Member

mhdawson commented Jan 9, 2020

@gms1 if you pull in @legendecas suggested change we can move forward in landing this.

@gms1 @legendecas
Update test/objectwrap.js
01f8a39 
Co-Authored-By: legendecas <legendecas@gmail.com>
@gabrielschulhof
Copy link
Contributor

CI:

Version Job Status
v14.x https://ci.nodejs.org/job/node-test-node-addon-api-new/1592/ ✓
v12.x https://ci.nodejs.org/job/node-test-node-addon-api-new/1593/ ✓
v10.x https://ci.nodejs.org/job/node-test-node-addon-api-new/1594/ ✓

gabrielschulhof pushed a commit that referenced this pull request Jan 10, 2020
@gms1
test: add test for own properties on ObjectWrap
e8935bd 
PR-URL: #645
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@gabrielschulhof
Copy link
Contributor

Landed in e8935bd.

kevindavies8 added a commit to kevindavies8/node-addon-api-Develop that referenced this pull request Aug 24, 2022
@kevindavies8
test: add test for own properties on ObjectWrap
d66ac3f 
PR-URL: nodejs/node-addon-api#645
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Marlyfleitas added a commit to Marlyfleitas/node-api-addon-Development that referenced this pull request Aug 26, 2022
@Marlyfleitas
test: add test for own properties on ObjectWrap
2013d7a 
PR-URL: nodejs/node-addon-api#645
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
wroy7860 added a commit to wroy7860/addon-api-benchmark-node that referenced this pull request Sep 19, 2022
@wroy7860
test: add test for own properties on ObjectWrap
d14c573 
PR-URL: nodejs/node-addon-api#645
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
johnfrench3 pushed a commit to johnfrench3/node-addon-api-git that referenced this pull request Aug 11, 2023
test: add test for own properties on ObjectWrap
b67b230 
PR-URL: nodejs/node-addon-api#645
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhdawson mhdawson mhdawson approved these changes

@legendecas legendecas legendecas approved these changes

@gabrielschulhof gabrielschulhof gabrielschulhof approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ObjectWrap: enumerable properties seem to be broken
4 participants
@gms1 @mhdawson @gabrielschulhof @legendecas