Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: change guards for BigInt to NAPI_VERSION > 5 #694

Closed

Commits on Apr 6, 2020

  1. src: fix AsyncProgressQueueWorker compilation

    We need to cast the `nullptr` to the templated type of the
    `AsyncProgressQueueWorker`.
    
    Fixes: nodejs#695
    PR-URL: nodejs#696
    Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com>
    Gabriel Schulhof committed Apr 6, 2020
    Configuration menu
    Copy the full SHA
    63f8f01 View commit details
    Browse the repository at this point in the history
  2. src: change guards to NAPI_VERSION > 5

    Since we have made the decision that we shall include `BigInt` into
    N-API 6, we can change the guards for the `BigInt` and `BigInt`-based
    typed array wrappers accordingly.
    Gabriel Schulhof committed Apr 6, 2020
    Configuration menu
    Copy the full SHA
    44e7688 View commit details
    Browse the repository at this point in the history