test: run in both a child process and a worker thread #738
Conversation
gabrielschulhof
requested review from
NickNaso,
legendecas,
KevinEady and
mhdawson
|
The CI failure might be related to nodejs/node#33508? |
|
@gabrielschulhof With my test I wanted to try use SetInstanceData/GetInstanceData in different threads at the same time. But the test was crashed by working different addons at same thread (addon_data and objectwrap). You new testrunner starts each addon at a new process. |
|
@anfilat understood. In that case, that's probably a test case to add to Node.js.core. |
|
@legendecas I had to fix the threadsafe_function_sum test because it was quitting before the promise was resolved. Can you please take another look? |
gabrielschulhof
force-pushed
the
run-tests-in-workers2
branch
from
82bfab0 to
25b5985
Compare
|
This needs nodejs/node#33508 to be backported to 14.x and 12.x before it can land. |
|
CI: We're getting some intermittent segfaults. |
Re: nodejs#730 Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com>
The TSFN sum test was not waiting for all TSFN calls to complete before releasing the TSFN completely. The main thread must only release the TSFN and resolve the deferred if all calls have completed.
gabrielschulhof
force-pushed
the
run-tests-in-workers2
branch
from
25b5985 to
16cc763
Compare
|
Rebased. |
|
CI:
|
nodejs/node#33508 has been backported to 14.5.0 and 12.18.3. @gabrielschulhof is there any other blocking issue for this one? |
| } | ||
|
|
||
| testModules.forEach((name) => { | ||
| runOneChild(name, 'child'); |
There was a problem hiding this comment.
I'd worried that all the cases were started at the same time. Can we wait for one case to finish then start another one?
|
@gabrielschulhof did you mean to close this? |
Re: #730
Signed-off-by: @gabrielschulhof