Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: use assert.strictEqual() #777

Closed
wants to merge 2 commits into from
Closed

test: use assert.strictEqual() #777

wants to merge 2 commits into from

Conversation

Nishikoh
Copy link
Contributor

Fix #775

NickNaso
NickNaso reviewed Jul 27, 2020
View reviewed changes
test/threadsafe_function/threadsafe_function_existing_tsfn.js Outdated
Comment on lines 15 to 18
assert.strictEqual(typeof await testCall({ blocking: true, data: true }) , "number");
assert.strictEqual(typeof await testCall({ blocking: true, data: false }) , "undefined");
assert.strictEqual(typeof await testCall({ blocking: false, data: true }) , "number");
assert.strictEqual(typeof await testCall({ blocking: false, data: false }) , "undefined");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Nishikoh could you remove the space before the comma ","?
Es.

assert.strictEqual(typeof await testCall({ blocking: false, data: false }), "undefined");

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the review. Fixed it.

NickNaso
NickNaso approved these changes Jul 27, 2020
View reviewed changes
Copy link
Member

@NickNaso NickNaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@gabrielschulhof
Copy link
Contributor

gabrielschulhof commented Jul 27, 2020 •
edited
Loading

CI:

Version Job Status
v15.x https://ci.nodejs.org/job/node-test-node-addon-api-new/2526/ ✗
v14.x https://ci.nodejs.org/job/node-test-node-addon-api-new/2527/ ✓
v12.x https://ci.nodejs.org/job/node-test-node-addon-api-new/2528/ ✓
v10.x https://ci.nodejs.org/job/node-test-node-addon-api-new/2529/ ✓

@gabrielschulhof
Copy link
Contributor

On v15.x it fails for unrelated reasons – specifically, because the SetImmediate()ed finalizers have landed in core. Thus, getting the tests to pass may depend on #773.

mhdawson
mhdawson approved these changes Jul 30, 2020
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gabrielschulhof
Copy link
Contributor

Rebased.

@gabrielschulhof
Copy link
Contributor

gabrielschulhof commented Jul 30, 2020 •
edited
Loading

CI:

Version Job Status
v15.x https://ci.nodejs.org/job/node-test-node-addon-api-new/2552/ ✓
v14.x https://ci.nodejs.org/job/node-test-node-addon-api-new/2553/ ✓
v12.x https://ci.nodejs.org/job/node-test-node-addon-api-new/2554/ ✓
v10.x https://ci.nodejs.org/job/node-test-node-addon-api-new/2555/ ✓

gabrielschulhof pushed a commit that referenced this pull request Jul 30, 2020
@Nishikoh
test: use assert.strictEqual()
4ce40d2 
Fixes: #775
PR-URL: #777
Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@gmail.com>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@gabrielschulhof
Copy link
Contributor

Landed in 4ce40d2.

kevindavies8 added a commit to kevindavies8/node-addon-api-Develop that referenced this pull request Aug 24, 2022
@kevindavies8
test: use assert.strictEqual()
fe758b7 
Fixes: nodejs/node-addon-api#775
PR-URL: nodejs/node-addon-api#777
Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@gmail.com>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Marlyfleitas added a commit to Marlyfleitas/node-api-addon-Development that referenced this pull request Aug 26, 2022
@Marlyfleitas
test: use assert.strictEqual()
d8f1b04 
Fixes: nodejs/node-addon-api#775
PR-URL: nodejs/node-addon-api#777
Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@gmail.com>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
wroy7860 added a commit to wroy7860/addon-api-benchmark-node that referenced this pull request Sep 19, 2022
@wroy7860
test: use assert.strictEqual()
13faf2d 
Fixes: nodejs/node-addon-api#775
PR-URL: nodejs/node-addon-api#777
Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@gmail.com>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
johnfrench3 pushed a commit to johnfrench3/node-addon-api-git that referenced this pull request Aug 11, 2023
test: use assert.strictEqual()
323f97e 
Fixes: nodejs/node-addon-api#775
PR-URL: nodejs/node-addon-api#777
Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@gmail.com>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhdawson mhdawson mhdawson approved these changes

@gabrielschulhof gabrielschulhof gabrielschulhof approved these changes

@NickNaso NickNaso NickNaso approved these changes

Assignees
No one assigned
Labels
blocked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test/threadsafe_function/threadsafe_function_existing_tsfn.js: use assert.strictEqual()
4 participants
@Nishikoh @gabrielschulhof @NickNaso @mhdawson