Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: refactor threadsafe_function test with async/await #787

Closed
wants to merge 1 commit into from
Closed

test: refactor threadsafe_function test with async/await #787

wants to merge 1 commit into from

Conversation

Velmisov
Copy link
Contributor

@Velmisov Velmisov commented Aug 7, 2020

KevinEady
KevinEady approved these changes Aug 9, 2020
View reviewed changes
Copy link
Contributor

@KevinEady KevinEady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM! I was able to also use this format in my draft tsfnex pull

mhdawson
mhdawson approved these changes Aug 24, 2020
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mhdawson pushed a commit that referenced this pull request Aug 24, 2020
@Velmisov @mhdawson
test: refactor test to use async/await
2bc45bb 
Refactor threadsafe_function test with async/await

PR-URL: #787
Reviewed-By: Kevin Eady <kevin.c.eady@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@mhdawson
Copy link
Member

Landed as 2bc45bb

@mhdawson mhdawson closed this Aug 24, 2020
@NickNaso NickNaso mentioned this pull request Sep 4, 2020
Closed
kevindavies8 added a commit to kevindavies8/node-addon-api-Develop that referenced this pull request Aug 24, 2022
@kevindavies8
test: refactor test to use async/await
da7a74d 
Refactor threadsafe_function test with async/await

PR-URL: nodejs/node-addon-api#787
Reviewed-By: Kevin Eady <kevin.c.eady@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Marlyfleitas added a commit to Marlyfleitas/node-api-addon-Development that referenced this pull request Aug 26, 2022
@Marlyfleitas
test: refactor test to use async/await
7201db6 
Refactor threadsafe_function test with async/await

PR-URL: nodejs/node-addon-api#787
Reviewed-By: Kevin Eady <kevin.c.eady@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
wroy7860 added a commit to wroy7860/addon-api-benchmark-node that referenced this pull request Sep 19, 2022
@wroy7860
test: refactor test to use async/await
d8f1551 
Refactor threadsafe_function test with async/await

PR-URL: nodejs/node-addon-api#787
Reviewed-By: Kevin Eady <kevin.c.eady@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
johnfrench3 pushed a commit to johnfrench3/node-addon-api-git that referenced this pull request Aug 11, 2023
test: refactor test to use async/await
678de87 
Refactor threadsafe_function test with async/await

PR-URL: nodejs/node-addon-api#787
Reviewed-By: Kevin Eady <kevin.c.eady@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhdawson mhdawson mhdawson approved these changes

@KevinEady KevinEady KevinEady approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Velmisov @mhdawson @KevinEady