Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix typos in addon_build/index.js #838

Closed
wants to merge 1 commit into from
Closed

test: fix typos in addon_build/index.js #838

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions test/addon_build/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
'use strict';

const { promisify } = require('util');
const exec = promisify(require('child_process').exec);
const exec = promisify(require('child_process').exec);
const { copy, remove } = require('fs-extra');
const path = require('path');
const assert = require('assert')
Expand All @@ -26,8 +26,8 @@ async function test(addon) {
const { stderr, stdout } = await exec('npm install', {
cwd: path.join(ADDONS_FOLDER, addon)
})
console.log(` >Runting test for: '${addon}'`);
// Disabled the checks on stderr and stdout because of this issuue on npm:
console.log(` >Running test for: '${addon}'`);
// Disabled the checks on stderr and stdout because of this issue on npm:
// Stop using process.umask(): https://github.com/npm/cli/issues/1103
// We should enable the following checks again after the resolution of
// the reported issue.
Expand All @@ -41,7 +41,6 @@ async function test(addon) {
assert.strictEqual(binding.noexcept.echo(103), 103);
}


module.exports = (async function() {
await beforeAll(addons);
for (const addon of addons) {
Expand Down