Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added badges for Node-API v7 and v8. #954

Merged
merged 1 commit into from
Apr 12, 2021
Merged

Conversation

NickNaso
Copy link
Member

This PR add new badges for Node-API v7 and v8.
The PR should be landed after:

@NickNaso NickNaso added the doc label Mar 27, 2021
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson
Copy link
Member

@NickNaso can you rebase, there was a PR that landed which updated to point to the Node-api vesions (versus n-api) and this is causing a conflict.

@mhdawson mhdawson merged commit 5e64d1f into nodejs:main Apr 12, 2021
deepakrkris pushed a commit to deepakrkris/node-addon-api that referenced this pull request Sep 23, 2021
deepakrkris pushed a commit to deepakrkris/node-addon-api that referenced this pull request Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants