Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

the original C code do not compile with the current node binary. #533

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

the original C code do not compile with the current node binary. #533

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/5-async-work/async_work_thread_safe_function/napi/binding.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ static napi_value StartThread(napi_env env, napi_callback_info info) {
}

// Free the per-addon-instance data.
static void addon_getting_unloaded(napi_env env, void* data, void* hint) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

napi_env should be the preferred type. Would you mind elaborating on the errors to be fixed?

static void addon_getting_unloaded(const struct napi_env__ *env, void* data, void* hint) {
AddonData* addon_data = (AddonData*)data;
assert(addon_data->work == NULL &&
"No work item in progress at module unload");
Expand Down
2 changes: 1 addition & 1 deletion src/6-threadsafe-function/thread_safe_function_round_trip/napi/round_trip.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,7 +342,7 @@ static napi_value GetPrime(napi_env env, napi_callback_info info) {
return prime_property;
}

static void addon_is_unloading(napi_env env, void* data, void* hint) {
static void addon_is_unloading(const struct napi_env__ *env, void* data, void* hint) {
AddonData* addon_data = (AddonData*)data;
uv_mutex_destroy(&(addon_data->check_status_mutex));
CHECK(napi_delete_reference(env,
Expand Down