Skip to content
This repository has been archived by the owner on Oct 15, 2020. It is now read-only.

Commit

Permalink
win,gyp: fix visual studio auto version map
Browse files Browse the repository at this point in the history
The VS "auto" version map was missing 14.0. Also preferred version
should be listed first. This problem is why we had to specify
--msvs_version=2015 to node-gyp. With this fix VS 2015 is auto selected.

Note: The newer version of related files on GitHub TooTallNate/node-gyp
already have this.

Reviewed-by: orangemocha
  • Loading branch information
Jianchun Xu committed Jun 4, 2015
1 parent eee57b1 commit b2c6cdd
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion tools/gyp/pylib/gyp/MSVSVersion.py
Original file line number Diff line number Diff line change
Expand Up @@ -399,7 +399,7 @@ def SelectVisualStudioVersion(version='auto'):
if version == 'auto':
version = os.environ.get('GYP_MSVS_VERSION', 'auto')
version_map = {
'auto': ('10.0', '12.0', '9.0', '8.0', '11.0'),
'auto': ('14.0', '12.0', '10.0', '9.0', '8.0', '11.0'),
'2005': ('8.0',),
'2005e': ('8.0',),
'2008': ('9.0',),
Expand Down

0 comments on commit b2c6cdd

Please sign in to comment.