Skip to content
This repository has been archived by the owner on Oct 15, 2020. It is now read-only.

Commit

Permalink
deps: update ChakraCore to chakra-core/ChakraCore@e1f5b03915
Browse files Browse the repository at this point in the history
[MERGE #6244 @wyrichte] Move signing for ChakraCore.dll and ch.exe to use a SHA2 cert

Merge pull request #6244 from wyrichte:build/wyrichte/will_this_work

Reviewed-By: chakrabot <chakrabot@users.noreply.github.com>
  • Loading branch information
wyrichte authored and chakrabot committed Aug 14, 2019
1 parent ea7eb7b commit bc53ba2
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion deps/chakrashim/core/bin/ChakraCore/ChakraCore.vcxproj
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@
<!-- Conditionally include the group of files to sign because MBv2 knows what to do with this but the old build definition gets confused. -->
<ItemGroup Condition="'$(VSO_MICROBUILD_V2)'=='True' AND '$(POGO_TYPE)'!='PGI'">
<FilesToSign Include="$(OutDir)\ChakraCore.dll">
<Authenticode>Microsoft</Authenticode>
<Authenticode>Microsoft400</Authenticode>
</FilesToSign>
</ItemGroup>
<Import Project="$(BuildConfigPropsPath)Chakra.Build.targets" Condition="exists('$(BuildConfigPropsPath)Chakra.Build.targets')" />
Expand Down
2 changes: 1 addition & 1 deletion deps/chakrashim/core/bin/ch/ch.vcxproj
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@
<!-- Conditionally include the group of files to sign because MBv2 knows what to do with this but the old build definition gets confused. -->
<ItemGroup Condition="'$(VSO_MICROBUILD_V2)'=='True' AND '$(POGO_TYPE)'!='PGI'">
<FilesToSign Include="$(OutDir)\ch.exe">
<Authenticode>Microsoft</Authenticode>
<Authenticode>Microsoft400</Authenticode>
</FilesToSign>
</ItemGroup>
<Import Project="$(BuildConfigPropsPath)Chakra.Build.targets" Condition="exists('$(BuildConfigPropsPath)Chakra.Build.targets')" />
Expand Down

0 comments on commit bc53ba2

Please sign in to comment.