Skip to content
This repository has been archived by the owner on Oct 15, 2020. It is now read-only.

Investigate test-inspector-exception failure #306

Closed
kunalspathak opened this issue Jun 16, 2017 · 1 comment
Closed

Investigate test-inspector-exception failure #306

kunalspathak opened this issue Jun 16, 2017 · 1 comment
Assignees
@kfarnung

Comments

@kunalspathak
Copy link
Member

  • Version:
  • Platform:
  • Subsystem:

As part of 4f8f708 test-inspector-exception was failing. I have marked it as flaky for now.
@kfarnung
Copy link
Contributor

kfarnung commented Jun 16, 2017 •
edited
Loading

@kunalspathak It's already fixed in 7517f97, you should be able to just cherry-pick the change.

kfarnung added a commit to kfarnung/node-chakracore that referenced this issue Jun 16, 2017
@kfarnung
test: fixing inspector test breaks
348cc62 
* Updated `inspector/test-inspector-exception` which required
  ChakraCore-specific logic and removed the flaky status
* Marked `inspector/test-off-with-session-then-on` flaky; failure
  tracked by nodejs#292

Fixes nodejs#306

PR-URL: nodejs#307
Reviewed-By: Kunal Pathak <kunal.pathak@microsoft.com>
kfarnung added a commit to kfarnung/node-chakracore that referenced this issue Jun 16, 2017
@kfarnung
test: fixing inspector test breaks
f4b0e23 
Updated `inspector/test-inspector-exception` which required
ChakraCore-specific logic and removed the flaky status

Fixes nodejs#306

PR-URL: nodejs#307
Reviewed-By: Kunal Pathak <kunal.pathak@microsoft.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kfarnung kfarnung

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kfarnung @kunalspathak