This repository has been archived by the owner on Oct 15, 2020. It is now read-only.
Atomics notify vs. wake #565
Comments
kfarnung
added a commit
to kfarnung/node-chakracore
that referenced
this issue
Jul 10, 2018
The `Intl` usage in the the shim is causing issues in ChakraCore on Linux and Mac. Since we don't necessarily need the `Atomics.notify` shim code either the simplest solution is to remove the shim completely for ChakraCore. Refs: nodejs#565
2 tasks
kfarnung
added a commit
to kfarnung/node-chakracore
that referenced
this issue
Jul 10, 2018
The `Intl` usage in the the shim is causing issues in ChakraCore on Linux and Mac. Since we don't necessarily need the `Atomics.notify` shim code either the simplest solution is to remove the shim completely for ChakraCore. Refs: nodejs#565 Refs: nodejs#567
kfarnung
added a commit
to kfarnung/node-chakracore
that referenced
this issue
Jul 10, 2018
The `Intl` usage in the the shim is causing issues in ChakraCore on Linux and Mac. Since we don't necessarily need the `Atomics.notify` shim code either the simplest solution is to remove the shim completely for ChakraCore. Refs: nodejs#565 Refs: nodejs#567 PR-URL: nodejs#566 Reviewed-By: Hitesh Kanwathirtha <hiteshk@microsoft.com> Reviewed-By: Jimmy Thomson <jithomso@microsoft.com>
kfarnung
added a commit
to kfarnung/node-chakracore
that referenced
this issue
Jul 10, 2018
The `Intl` usage in the the shim is causing issues in ChakraCore on Linux and Mac. Since we don't necessarily need the `Atomics.notify` shim code either the simplest solution is to remove the shim completely for ChakraCore. Refs: nodejs#565 Refs: nodejs#567 PR-URL: nodejs#566 Reviewed-By: Hitesh Kanwathirtha <hiteshk@microsoft.com> Reviewed-By: Jimmy Thomson <jithomso@microsoft.com>
|
Looks like this is blocking some new features: nodejs/node#22835 This depends on #567 |
kfarnung
added a commit
to kfarnung/node-chakracore
that referenced
this issue
Sep 18, 2018
This reverts commit f5d29d5. It also updates the shim to use shim `wake` using `notify`. Refs: nodejs#565 Refs: nodejs#567
kfarnung
added a commit
to kfarnung/node-chakracore
that referenced
this issue
Sep 18, 2018
This reverts commit f5d29d5. It also updates the shim to use shim `wake` using `notify`. Refs: nodejs#565 Refs: nodejs#567 Refs: nodejs/node#22844
kfarnung
added a commit
to kfarnung/node-chakracore
that referenced
this issue
Sep 18, 2018
This reverts commit f5d29d5. PR-URL: nodejs#600 Refs: nodejs#565 Refs: nodejs#567 Reviewed-By: Jimmy Thomson <jithomso@microsoft.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Jack Horton <Jack.Horton@microsoft.com>
kfarnung
added a commit
to kfarnung/node-chakracore
that referenced
this issue
Sep 20, 2018
This reverts commit f5d29d5. PR-URL: nodejs#600 Refs: nodejs#565 Refs: nodejs#567 Reviewed-By: Jimmy Thomson <jithomso@microsoft.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Jack Horton <Jack.Horton@microsoft.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
ChakraCore 1.9 currently has
Atomics.wakewhich has been renamed toAtomics.notifywhich has been updated in ChakraCore 1.10. The shim is being disabled for now to work aroundIntlissues and we'll re-investigate whether to enable it again when ChakraCore 1.10 lands.The text was updated successfully, but these errors were encountered: