This repository has been archived by the owner on Oct 15, 2020. It is now read-only.
build: disable MSI by default for ChakraCore #139
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. |
|
LGTM |
joaocgreis
added a commit
that referenced
this pull request
Nov 16, 2016
Reviewed-By: Kunal Pathak <Kunal.Pathak@microsoft.com> Reviewed-By: Hitesh Kanwathirtha <hiteshk@microsoft.com> PR-URL: #139
joaocgreis
added a commit
that referenced
this pull request
Nov 16, 2016
Reviewed-By: Kunal Pathak <Kunal.Pathak@microsoft.com> Reviewed-By: Hitesh Kanwathirtha <hiteshk@microsoft.com> PR-URL: #139
|
CI: https://ci.nodejs.org/view/All/job/chakracore-test-windows/23/ (failures unrelated) |
Seems there is a build error that we need to track down.
c:\workspace\node-test-binary-windows\RUN_SUBSET\2\VS_VERSION\vs2015\label\win2012r2\deps\chakrashim\include\v8.h(58): fatal error C1083: Cannot open include file: 'chakracore.h': No such file or directory [c:\workspace\node-test-binary-windows\RUN_SUBSET\2\VS_VERSION\vs2015\label\win2012r2\test\addons\06_passing_wrapped_objects_around\build\addon.vcxproj]The only change that went in after last known good build is 99d6392. @agarwal-sandeep , can you check if this is not related to your commit? |
joaocgreis
added a commit
to joaocgreis/node-chakracore
that referenced
this pull request
Nov 16, 2016
2 tasks
joaocgreis
added a commit
to joaocgreis/node-chakracore
that referenced
this pull request
Nov 17, 2016
|
Closing, as the changes have landed already. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
Build
Description of change
The MSI as currently generated in node-chakracore is very similar to the V8 MSI, and may cause unexpected conflicts if not used carefully. This disables MSI generation by default as part of the releases, but it can still be generated with
vcbuild msi.This should land in both
chakracore-masterandxplat.Ref: nodejs/build#527
cc @nodejs/node-chakracore