Skip to content
This repository has been archived by the owner on Oct 15, 2020. It is now read-only.

Merge N-API JSRT implementation from abi-stable-node #238

Merged
merged 4 commits into from
May 15, 2017
Merged

Merge N-API JSRT implementation from abi-stable-node #238

merged 4 commits into from
May 15, 2017

Commits on May 15, 2017

  1. n-api: Merge N-API JSRT from abi-stable-node 

     - Copy `node_api_jsrt.cc` from abi-stable-node fork
 - Update `node_api_jsrt.cc` for renamed JSRT string APIs:
   `JsCopyStringUtf8` -> `JsCopyString`, etc
 - Update `node.gyp` to build `node_api_jsrt.cc` instead of
   `node_api.cc`
 - Temporarily disable 2 N-API test cases with known failures

PR-URL: nodejs#238
Reviewed-By: Taylor Woll <taylor.woll@microsoft.com>
Reviewed-By: Kyle Farnung <kfarnung@microsoft.com>
    @jasongin @kfarnung
    jasongin authored and kfarnung committed May 15, 2017
    Configuration menu
    Copy the full SHA
    5cad632 View commit details
    Browse the repository at this point in the history

  2. n-api: Fix cc lint errors in node_api_jsrt.cc 

    PR-URL: nodejs#238
Reviewed-By: Taylor Woll <taylor.woll@microsoft.com>
Reviewed-By: Kyle Farnung <kfarnung@microsoft.com>
    @boingoing @kfarnung
    boingoing authored and kfarnung committed May 15, 2017
    Configuration menu
    Copy the full SHA
    f8cbdde View commit details
    Browse the repository at this point in the history

  3. n-api: Make sources conditional on V8 / ChakraCore 

    PR-URL: nodejs#238
Reviewed-By: Taylor Woll <taylor.woll@microsoft.com>
Reviewed-By: Kyle Farnung <kfarnung@microsoft.com>
    @jasongin @kfarnung
    jasongin authored and kfarnung committed May 15, 2017
    Configuration menu
    Copy the full SHA
    cc20967 View commit details
    Browse the repository at this point in the history

  4. n-api: Minor updates for review feedback 

    PR-URL: nodejs#238
Reviewed-By: Taylor Woll <taylor.woll@microsoft.com>
Reviewed-By: Kyle Farnung <kfarnung@microsoft.com>
    @jasongin @kfarnung
    jasongin authored and kfarnung committed May 15, 2017
    Configuration menu
    Copy the full SHA
    28cdc33 View commit details
    Browse the repository at this point in the history