Skip to content
This repository has been archived by the owner on Oct 15, 2020. It is now read-only.

chakrashim: fix console autocomplete in VS Code #356

Merged
merged 1 commit into from
Aug 4, 2017

Commits on Aug 4, 2017

  1. chakrashim: fix console autocomplete in VS Code

    The autocomplete for VS Code (and probably Chrome) sends a blob of
    JavaScript to the engine which enumerates/filters the properties and
    returns them. The code wasn't respecting the `returnByValue` parameter
    and VS Code was unable to get the length of the undefined `value` field
    in the response.
    
    While I was in there I also removed some unneeded fields from the
    `JavaScriptCallFrame` class and fixed a build warning (C4800) in v8.h.
    
    PR-URL: nodejs#356
    Reviewed-By: Jimmy Thomson <jithomso@microsoft.com>
    kfarnung committed Aug 4, 2017
    Configuration menu
    Copy the full SHA
    fb72fa2 View commit details
    Browse the repository at this point in the history