Skip to content
This repository has been archived by the owner on Oct 15, 2020. It is now read-only.

build: fix ./configure --xcode failure #376

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

tommyZZM
Copy link

@tommyZZM tommyZZM commented Aug 20, 2017

make ./configure --xcode is able to generate .xcodeproj and build all targets successfully

reference: #297

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

None

@tommyZZM tommyZZM closed this Aug 20, 2017
@tommyZZM tommyZZM reopened this Aug 20, 2017
@obastemur
Copy link
Contributor

I guess that you assume this work if you have compiled chakracore already? And don't include ChakraCore in xcode?

@tommyZZM
Copy link
Author

hi @obastemur

chakracore.xcodeproj and chakrashim.xcodeproj are both included and compile by xcode successfully

@obastemur
Copy link
Contributor

chakracore.xcodeproj and chakrashim.xcodeproj are both included and compile by xcode successfully

They are there because of chakracore.gyp and chakrashim.gyp are exist. ChakraCore build system is CMake. You can't create chakracore's xcode project by exporting xcode from gyp.

Besides, the changes to configure needs some attention.

Thanks for the attempt.

This; being automated, may require a bit more hacking.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants