This repository was archived by the owner on Oct 15, 2020. It is now read-only.
chakrashim: fixing ObjectTemplate regression #435
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MSLaguana
approved these changes
Nov 29, 2017
Contributor
Author
During some adhoc testing I found that HasOwnProperty behavior regressed for objects created with value properties. I reworked the callback to early exit when a property descriptor callback returns a valid descriptor and restored the rest of the function logic back. Refs: 5fed2d6 PR-URL: nodejs#435 Reviewed-By: Jimmy Thomson <jithomso@microsoft.com>
kfarnung
force-pushed
the
objtemplate
branch
from
bc5902a to
cf8b577
Compare
kfarnung
added a commit
to kfarnung/node-chakracore
that referenced
this pull request
Jan 10, 2018
During some adhoc testing I found that HasOwnProperty behavior regressed for objects created with value properties. I reworked the callback to early exit when a property descriptor callback returns a valid descriptor and restored the rest of the function logic back. Refs: 5fed2d6 PR-URL: nodejs#435 Reviewed-By: Jimmy Thomson <jithomso@microsoft.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During some adhoc testing I found that HasOwnProperty behavior
regressed for objects created with value properties. I reworked the
callback to early exit when a property descriptor callback returns a
valid descriptor and restored the rest of the function logic back.
Refs: 5fed2d6
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
chakrashim