This repository was archived by the owner on Oct 15, 2020. It is now read-only.
chakrashim: fixing misc lint issues #441
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
MSLaguana
approved these changes
Dec 8, 2017
* Replaced usages of NULL with nullptr * Fixed indentation in class PR-URL: nodejs#441 Reviewed-By: Jimmy Thomson <jithomso@microsoft.com> Reviewed-By: Taylor Woll <taylor.woll@microsoft.com>
PR-URL: nodejs#441 Reviewed-By: Jimmy Thomson <jithomso@microsoft.com> Reviewed-By: Taylor Woll <taylor.woll@microsoft.com>
kfarnung
added a commit
to kfarnung/node-chakracore
that referenced
this pull request
Jan 10, 2018
* Replaced usages of NULL with nullptr * Fixed indentation in class PR-URL: nodejs#441 Reviewed-By: Jimmy Thomson <jithomso@microsoft.com> Reviewed-By: Taylor Woll <taylor.woll@microsoft.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
chakrashim