Skip to content
This repository was archived by the owner on Oct 15, 2020. It is now read-only.

Prefer let and const #476

Merged
kfarnung merged 3 commits into from
Feb 27, 2018
Merged

Prefer let and const #476

kfarnung merged 3 commits into from
Feb 27, 2018

Conversation

@kfarnung
Copy link
Contributor

@kfarnung kfarnung commented Feb 24, 2018

While cleaning up some lint issues I ended up cleaning up the code to prefer let and const over var, except for loop variables.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

chakrashim, lib

@kfarnung kfarnung self-assigned this Feb 24, 2018
kfarnung added a commit to kfarnung/node-chakracore that referenced this pull request Feb 26, 2018
@kfarnung
lib: update TTD to use let and const
a23b64f 
PR-URL: nodejs#476
Reviewed-By: Jack Horton <Jack.Horton@microsoft.com>
Reviewed-By: Taylor Woll <tawoll@ntdev.microsoft.com>
Reviewed-By: Seth Brenith <sethb@microsoft.com>
Reviewed-By: Jimmy Thomson <jithomso@microsoft.com>
kfarnung added a commit to kfarnung/node-chakracore that referenced this pull request Feb 26, 2018
@kfarnung
chakrashim: switch var to let and const
4c8c9ba 
PR-URL: nodejs#476
Reviewed-By: Jack Horton <Jack.Horton@microsoft.com>
Reviewed-By: Taylor Woll <tawoll@ntdev.microsoft.com>
Reviewed-By: Seth Brenith <sethb@microsoft.com>
Reviewed-By: Jimmy Thomson <jithomso@microsoft.com>
@kfarnung
Copy link
Contributor Author

kfarnung commented Feb 26, 2018 •
edited
Loading

CI: https://ci.nodejs.org/job/chakracore-test-pull-request/205/
https://ci.nodejs.org/job/chakracore-test-pull-request/206/
https://ci.nodejs.org/job/chakracore-test-pull-request/207/

kfarnung added a commit to kfarnung/node-chakracore that referenced this pull request Feb 26, 2018
@kfarnung
lib: update TTD to use let and const
286ad3d 
PR-URL: nodejs#476
Reviewed-By: Jack Horton <Jack.Horton@microsoft.com>
Reviewed-By: Taylor Woll <tawoll@ntdev.microsoft.com>
Reviewed-By: Seth Brenith <sethb@microsoft.com>
Reviewed-By: Jimmy Thomson <jithomso@microsoft.com>
kfarnung added a commit to kfarnung/node-chakracore that referenced this pull request Feb 26, 2018
@kfarnung
chakrashim: switch var to let and const
6d0732b 
PR-URL: nodejs#476
Reviewed-By: Jack Horton <Jack.Horton@microsoft.com>
Reviewed-By: Taylor Woll <tawoll@ntdev.microsoft.com>
Reviewed-By: Seth Brenith <sethb@microsoft.com>
Reviewed-By: Jimmy Thomson <jithomso@microsoft.com>
kfarnung added a commit to kfarnung/node-chakracore that referenced this pull request Feb 26, 2018
@kfarnung
doc: fix Markdown linter failures
f1a548a 
PR-URL: nodejs#476
Reviewed-By: Jack Horton <Jack.Horton@microsoft.com>
Reviewed-By: Taylor Woll <tawoll@ntdev.microsoft.com>
Reviewed-By: Seth Brenith <sethb@microsoft.com>
Reviewed-By: Jimmy Thomson <jithomso@microsoft.com>
kfarnung added a commit to kfarnung/node-chakracore that referenced this pull request Feb 26, 2018
@kfarnung
lib: update TTD to use let and const
766337a 
PR-URL: nodejs#476
Reviewed-By: Jack Horton <Jack.Horton@microsoft.com>
Reviewed-By: Taylor Woll <tawoll@ntdev.microsoft.com>
Reviewed-By: Seth Brenith <sethb@microsoft.com>
Reviewed-By: Jimmy Thomson <jithomso@microsoft.com>
kfarnung added a commit to kfarnung/node-chakracore that referenced this pull request Feb 26, 2018
@kfarnung
chakrashim: switch var to let and const
3b53ef3 
PR-URL: nodejs#476
Reviewed-By: Jack Horton <Jack.Horton@microsoft.com>
Reviewed-By: Taylor Woll <tawoll@ntdev.microsoft.com>
Reviewed-By: Seth Brenith <sethb@microsoft.com>
Reviewed-By: Jimmy Thomson <jithomso@microsoft.com>
kfarnung added a commit to kfarnung/node-chakracore that referenced this pull request Feb 26, 2018
@kfarnung
doc: fix Markdown linter failures
fd2cf58 
PR-URL: nodejs#476
Reviewed-By: Jack Horton <Jack.Horton@microsoft.com>
Reviewed-By: Taylor Woll <tawoll@ntdev.microsoft.com>
Reviewed-By: Seth Brenith <sethb@microsoft.com>
Reviewed-By: Jimmy Thomson <jithomso@microsoft.com>
@kfarnung
lib: update TTD to use let and const
5edf74d 
PR-URL: nodejs#476
Reviewed-By: Jack Horton <Jack.Horton@microsoft.com>
Reviewed-By: Taylor Woll <tawoll@ntdev.microsoft.com>
Reviewed-By: Seth Brenith <sethb@microsoft.com>
Reviewed-By: Jimmy Thomson <jithomso@microsoft.com>
@kfarnung
chakrashim: switch var to let and const
2fb4e28 
PR-URL: nodejs#476
Reviewed-By: Jack Horton <Jack.Horton@microsoft.com>
Reviewed-By: Taylor Woll <tawoll@ntdev.microsoft.com>
Reviewed-By: Seth Brenith <sethb@microsoft.com>
Reviewed-By: Jimmy Thomson <jithomso@microsoft.com>
@kfarnung
doc: fix Markdown linter failures
2552d1c 
PR-URL: nodejs#476
Reviewed-By: Jack Horton <Jack.Horton@microsoft.com>
Reviewed-By: Taylor Woll <tawoll@ntdev.microsoft.com>
Reviewed-By: Seth Brenith <sethb@microsoft.com>
Reviewed-By: Jimmy Thomson <jithomso@microsoft.com>
@kfarnung kfarnung merged commit 2552d1c into nodejs:master Feb 27, 2018
@kfarnung kfarnung deleted the decl branch February 27, 2018 01:26
kfarnung added a commit to kfarnung/node-chakracore that referenced this pull request Feb 27, 2018
@kfarnung
chakrashim: switch var to let and const
8ce063d 
PR-URL: nodejs#476
Reviewed-By: Jack Horton <Jack.Horton@microsoft.com>
Reviewed-By: Taylor Woll <tawoll@ntdev.microsoft.com>
Reviewed-By: Seth Brenith <sethb@microsoft.com>
Reviewed-By: Jimmy Thomson <jithomso@microsoft.com>
kfarnung added a commit to kfarnung/node-chakracore that referenced this pull request Mar 6, 2018
@kfarnung
lib: update TTD to use let and const
07a60bd 
PR-URL: nodejs#476
Reviewed-By: Jack Horton <Jack.Horton@microsoft.com>
Reviewed-By: Taylor Woll <tawoll@ntdev.microsoft.com>
Reviewed-By: Seth Brenith <sethb@microsoft.com>
Reviewed-By: Jimmy Thomson <jithomso@microsoft.com>
kfarnung added a commit to kfarnung/node-chakracore that referenced this pull request Mar 6, 2018
@kfarnung
lib: update TTD to use let and const
9e3a1fa 
PR-URL: nodejs#476
Reviewed-By: Jack Horton <Jack.Horton@microsoft.com>
Reviewed-By: Taylor Woll <tawoll@ntdev.microsoft.com>
Reviewed-By: Seth Brenith <sethb@microsoft.com>
Reviewed-By: Jimmy Thomson <jithomso@microsoft.com>
kfarnung added a commit to kfarnung/node-chakracore that referenced this pull request Mar 6, 2018
@kfarnung
lib: update TTD to use let and const
f9b2857 
PR-URL: nodejs#476
Reviewed-By: Jack Horton <Jack.Horton@microsoft.com>
Reviewed-By: Taylor Woll <tawoll@ntdev.microsoft.com>
Reviewed-By: Seth Brenith <sethb@microsoft.com>
Reviewed-By: Jimmy Thomson <jithomso@microsoft.com>
kfarnung added a commit to kfarnung/node-chakracore that referenced this pull request Mar 6, 2018
@kfarnung
lib: update TTD to use let and const
5092774 
PR-URL: nodejs#476
Reviewed-By: Jack Horton <Jack.Horton@microsoft.com>
Reviewed-By: Taylor Woll <tawoll@ntdev.microsoft.com>
Reviewed-By: Seth Brenith <sethb@microsoft.com>
Reviewed-By: Jimmy Thomson <jithomso@microsoft.com>
kfarnung added a commit to kfarnung/node-chakracore that referenced this pull request Mar 6, 2018
@kfarnung
chakrashim: switch var to let and const
9df1c23 
PR-URL: nodejs#476
Reviewed-By: Jack Horton <Jack.Horton@microsoft.com>
Reviewed-By: Taylor Woll <tawoll@ntdev.microsoft.com>
Reviewed-By: Seth Brenith <sethb@microsoft.com>
Reviewed-By: Jimmy Thomson <jithomso@microsoft.com>
kfarnung added a commit to kfarnung/node-chakracore that referenced this pull request Mar 6, 2018
@kfarnung
lib: update TTD to use let and const
8c6e996 
PR-URL: nodejs#476
Reviewed-By: Jack Horton <Jack.Horton@microsoft.com>
Reviewed-By: Taylor Woll <tawoll@ntdev.microsoft.com>
Reviewed-By: Seth Brenith <sethb@microsoft.com>
Reviewed-By: Jimmy Thomson <jithomso@microsoft.com>
kfarnung added a commit to kfarnung/node-chakracore that referenced this pull request Mar 7, 2018
@kfarnung
chakrashim: switch var to let and const
9ab6df8 
PR-URL: nodejs#476
Reviewed-By: Jack Horton <Jack.Horton@microsoft.com>
Reviewed-By: Taylor Woll <tawoll@ntdev.microsoft.com>
Reviewed-By: Seth Brenith <sethb@microsoft.com>
Reviewed-By: Jimmy Thomson <jithomso@microsoft.com>
kfarnung added a commit to kfarnung/node-chakracore that referenced this pull request Mar 7, 2018
@kfarnung
lib: update TTD to use let and const
c3f8c94 
PR-URL: nodejs#476
Reviewed-By: Jack Horton <Jack.Horton@microsoft.com>
Reviewed-By: Taylor Woll <tawoll@ntdev.microsoft.com>
Reviewed-By: Seth Brenith <sethb@microsoft.com>
Reviewed-By: Jimmy Thomson <jithomso@microsoft.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

4 more reviewers

@sethbrenith sethbrenith sethbrenith approved these changes

@boingoing boingoing boingoing approved these changes

@jackhorton jackhorton jackhorton approved these changes

@MSLaguana MSLaguana MSLaguana approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@kfarnung kfarnung

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@kfarnung @sethbrenith @boingoing @jackhorton @MSLaguana