This repository was archived by the owner on Oct 15, 2020. It is now read-only.
chakrashim: Fix Error.captureStackTrace #483
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Error.captureStackTrace did not convert the type of line and column numbers to numbers while creating the v8 capture objects. This breaks modules which assumes number types. Changed to call parseInt if line and column numbers are defined
kfarnung
approved these changes
Mar 5, 2018
MSLaguana
approved these changes
Mar 5, 2018
digitalinfinity
added a commit
that referenced
this pull request
Mar 8, 2018
Error.captureStackTrace did not convert the type of line and column numbers to numbers while creating the v8 capture objects. This breaks modules which assumes number types. Changed to call parseInt if line and column numbers are defined PR-URL: #483 Reviewed-By: Kyle Farnung <kfarnung@microsoft.com> Reviewed-By: Jimmy Thomson <jithomso@microsoft.com>
Contributor
Author
|
Landed in 887e882. Thanks for the reviews! |
kfarnung
pushed a commit
to kfarnung/node-chakracore
that referenced
this pull request
Mar 8, 2018
Error.captureStackTrace did not convert the type of line and column numbers to numbers while creating the v8 capture objects. This breaks modules which assumes number types. Changed to call parseInt if line and column numbers are defined PR-URL: nodejs#483 Reviewed-By: Kyle Farnung <kfarnung@microsoft.com> Reviewed-By: Jimmy Thomson <jithomso@microsoft.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error.captureStackTrace did not convert the type of line and column
numbers to numbers while creating the v8 capture objects. This breaks
modules which assumes number types. Changed to call parseInt if line
and column numbers are defined
Note: this fixes the failing Winston test in CITGM
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
chakrashim