This repository was archived by the owner on Oct 15, 2020. It is now read-only.
src: update napi_get_new_target to match docs
#490
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MSLaguana
reviewed
Mar 8, 2018
| bool result; | ||
| napi_value newTargetArg; | ||
| NAPI_CALL(env, napi_get_new_target(env, info, &newTargetArg)); | ||
| napi_value undefined; |
Contributor
There was a problem hiding this comment.
Is this test change from upstream?
Contributor
Author
There was a problem hiding this comment.
This test doesn't exist upstream, @boingoing added it to node-chakracore. I'm planning to upstream the test as well. I found the issue when trying to build and test the V8 version of our branch.
MSLaguana
approved these changes
Mar 8, 2018
The implementation for `napi_get_new_target` needs to return nullptr when the function is not being called as a constructor. PR-URL: nodejs#490 Reviewed-By: Taylor Woll <tawoll@ntdev.microsoft.com> Reviewed-By: Jimmy Thomson <jithomso@microsoft.com>
kfarnung
added a commit
to kfarnung/node-chakracore
that referenced
this pull request
Mar 8, 2018
The implementation for `napi_get_new_target` needs to return nullptr when the function is not being called as a constructor. PR-URL: nodejs#490 Reviewed-By: Taylor Woll <tawoll@ntdev.microsoft.com> Reviewed-By: Jimmy Thomson <jithomso@microsoft.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation for
napi_get_new_targetneeds to return nullptrwhen the function is not being called as a constructor.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)