This repository was archived by the owner on Oct 15, 2020. It is now read-only.
test: prefer common.isChakraEngine
#493
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
jackhorton
approved these changes
Mar 9, 2018
Contributor
jackhorton
left a comment
jackhorton
left a comment
There was a problem hiding this comment.
Wasn't sure if it was preferable to edit the require(common) line or use process.jsEngine, good to know.
Replace usages of `process.jsEngine` in tests with `common.isChakraEngine` checks. PR-URL: nodejs#493 Reviewed-By: Jack Horton <Jack.Horton@microsoft.com>
kfarnung
added a commit
to kfarnung/node-chakracore
that referenced
this pull request
Mar 9, 2018
Replace usages of `process.jsEngine` in tests with `common.isChakraEngine` checks. PR-URL: nodejs#493 Reviewed-By: Jack Horton <Jack.Horton@microsoft.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace usages of
process.jsEnginein tests withcommon.isChakraEnginechecks.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes