Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.2.0 fails in node 14 #35

Closed
juliangruber opened this issue Aug 2, 2022 · 4 comments · Fixed by #36
Closed

3.2.0 fails in node 14 #35

juliangruber opened this issue Aug 2, 2022 · 4 comments · Fixed by #36
Labels
bug Something isn't working

Comments

@juliangruber
Copy link
Member

See eg juliangruber/parse-apache-directory-index#28

/Users/julian/dev/juliangruber/parse-apache-directory-index/node_modules/test/lib/internal/abort_controller.js:4
  AbortController,
  ^

ReferenceError: AbortController is not defined
    at Object.<anonymous> (/Users/julian/dev/juliangruber/parse-apache-directory-index/node_modules/test/lib/internal/abort_controller.js:4:3)

I wonder why tests didn't catch this. Is it because we pass our own AbortController implementation?

@juliangruber juliangruber added the bug Something isn't working label Aug 2, 2022
@aduh95
Copy link
Contributor

aduh95 commented Aug 2, 2022

There's catch in the README:

- Requires `--experimental-abortcontroller` CLI flag to work on Node.js v14.x.

@aduh95
Copy link
Contributor

aduh95 commented Aug 2, 2022

And here's how we're testing it:

matrix:
node: ['14', '16', '18']
include:
- node: '14'
env: --experimental-abortcontroller --no-warnings
- run: npm test
env:
NODE_OPTIONS: ${{ matrix.env }}

@juliangruber
Copy link
Member Author

Aah right I forgot about that. Thank you for pointing this out. I think this should have been a major version bump then.

@juliangruber
Copy link
Member Author

shall we deprecate 3.2.0 and publish 4.0.0?

aduh95 added a commit to aduh95/node-core-test that referenced this issue Aug 2, 2022
Fixes a breaking change for Node.js v14.x that was introduced in 3.2.0.

Fixes: nodejs#35
aduh95 added a commit to aduh95/node-core-test that referenced this issue Aug 3, 2022
Fixes a breaking change for Node.js v14.x that was introduced in 3.2.0.

Fixes: nodejs#35
@aduh95 aduh95 closed this as completed in #36 Aug 3, 2022
aduh95 added a commit that referenced this issue Aug 3, 2022
…36)

Fixes a breaking change for Node.js v14.x that was introduced in 3.2.0.

Fixes: #35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants