-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3.2.0 fails in node 14 #35
Labels
bug
Something isn't working
Comments
There's catch in the README: Line 14 in 1401584
|
And here's how we're testing it: node-core-test/.github/workflows/ci.yml Lines 10 to 14 in 558abfc
node-core-test/.github/workflows/ci.yml Lines 21 to 23 in 558abfc
|
Aah right I forgot about that. Thank you for pointing this out. I think this should have been a major version bump then. |
shall we deprecate 3.2.0 and publish 4.0.0? |
aduh95
added a commit
to aduh95/node-core-test
that referenced
this issue
Aug 2, 2022
Fixes a breaking change for Node.js v14.x that was introduced in 3.2.0. Fixes: nodejs#35
aduh95
added a commit
to aduh95/node-core-test
that referenced
this issue
Aug 3, 2022
Fixes a breaking change for Node.js v14.x that was introduced in 3.2.0. Fixes: nodejs#35
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
See eg juliangruber/parse-apache-directory-index#28
I wonder why tests didn't catch this. Is it because we pass our own AbortController implementation?
The text was updated successfully, but these errors were encountered: