Skip to content

Commit

Permalink
chore: update supported Node.js versions (#733)
Browse files Browse the repository at this point in the history
* chore: remove EoL Node.js 16 from test matrix
* chore: update engines in package.json
* chore: moved to prepare-node-test-matrix

BREAKING CHANGE: remove support from Node.js 16.x,17.x and 19.x.
  • Loading branch information
rluvaton authored Sep 24, 2023
1 parent 7382454 commit b727af2
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 23 deletions.
30 changes: 8 additions & 22 deletions .github/workflows/nodejs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,27 +22,13 @@ jobs:
run: npm run lint

test:
name: Test on Node.js ${{ matrix.node-version }} and ${{ matrix.os }}
name: Test on Node.js
uses: pkgjs/action/.github/workflows/node-test.yaml@v0
with:
runs-on: ubuntu-latest, macos-latest
test-command: npm run coverage:ci
post-test-steps: |
- name: Upload coverage report to Codecov
uses: codecov/codecov-action@v3
strategy:
fail-fast: false
matrix:
node-version: [16.x, 18.x, 20.x]
os: [ubuntu-latest, macOS-latest, windows-latest]
runs-on: ${{ matrix.os }}
steps:
- uses: actions/checkout@v3
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node-version }}
check-latest: true
- name: Install dependencies
run: npm install
- name: Run tests
if: matrix.node-version == '16.x'
run: npm run test-unit
- name: Run tests
if: matrix.node-version != '16.x'
run: npm run coverage:ci
- name: Upload coverage report to Codecov
uses: codecov/codecov-action@v3
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"description": "Utilities for Node.js core collaborators",
"type": "module",
"engines": {
"node": ">=16.8.0"
"node": "^18.18.0 || >=20.0.0"
},
"bin": {
"get-metadata": "./bin/get-metadata.js",
Expand Down

0 comments on commit b727af2

Please sign in to comment.