add warn msg for fast-track Pull Requests.

nodejs · Nov 11, 2017 · c45d459 · c45d459
1 parent 2899719
commit c45d459
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 4 deletions.
diff --git a/lib/pr_checker.js b/lib/pr_checker.js
@@ -152,9 +152,17 @@ class PRChecker {
     const { pr } = this;
     const { cli } = this;
     const labels = pr.labels.nodes;
+
+    let isFastTrack = false;
     const fast = labels.some((l) => isFast(l.name)) ||
       (labels.length === 1 && labels[0].name === 'doc');
+
+    if (isFastTrack) {
+      cli.info('This PR is being fast-tracked.');
+    }
+
     if (fast) { return true; }
+
     const wait = this.getWait(now);
     if (wait.timeLeft > 0) {
       const dateStr = new Date(pr.createdAt).toDateString();
@@ -165,7 +173,8 @@ class PRChecker {
     }
 
     function isFast(label) {
-      return (label === 'code-and-learn' || label === 'fast-track');
+      isFastTrack = label === 'fast-track';
+      return (label === 'code-and-learn' || isFastTrack);
     }
 
     return true;

diff --git a/test/unit/pr_checker.test.js b/test/unit/pr_checker.test.js
@@ -227,9 +227,10 @@ describe('PRChecker', () => {
     it('should skip wait check for fast-track labelled PR', () => {
       const cli = new TestCLI();
 
-      const expectedLogs = {};
+      const expectedLogs = {
+        info: [['This PR is being fast-tracked.']]
+      };
 
-      const now = new Date();
       const youngPR = Object.assign({}, firstTimerPR, {
         createdAt: '2017-10-27T14:25:41.682Z',
         labels: {
@@ -248,7 +249,7 @@ describe('PRChecker', () => {
         collaborators
       });
 
-      const status = checker.checkPRWait(now);
+      const status = checker.checkPRWait(new Date());
       assert(status);
       cli.assertCalledWith(expectedLogs);
     });