allow passing full URLs on the command line

i.e. make `get-metadata nodejs/node#16489 work
nodejs · Oct 25, 2017 · c7d4668 · c7d4668
1 parent 6f5e018
commit c7d4668
Showing 1 changed file with 11 additions and 1 deletion.
diff --git a/bin/metadata.js b/bin/metadata.js
@@ -25,7 +25,7 @@ const MetadataGenerator = require('../lib/metadata_gen');
 const OWNER = 'nodejs';
 const REPO = 'node';
 
-const PR_ID = parseInt(process.argv[2]); // example
+const PR_ID = parsePRId(process.argv[2]); // example
 
 async function main(prid, owner, repo) {
  logger.trace(`Getting collaborator contacts from README of ${owner}/${repo}`);
@@ -68,3 +68,13 @@ main(PR_ID, OWNER, REPO).catch((err) => {
  logger.error(err);
  process.exit(-1);
 });
+
+function parsePRId(id) {
+ // Fast path: numeric string
+ if (`${+id}` === id)
+ return +id;
+ const match = id.match(/^https:.*\/([0-9]+)$/);
+ if (match !== null)
+ return +match[1];
+ throw new Error(`Could not understand PR id format: ${id}`);
+}