-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
git node land simplifications #425
Comments
I like it, as long as there's an opt-out flag. I landed a commit recently with a mix of |
We should also automatically check if local master branch is already up to date and skip the suggestion ( |
Another improvement would be to ask if the user wants to push the commit ( |
This makes sure manual amend is started in case the user requested that without the need to edit any intermediate files. Refs: nodejs#425
|
This issue is stale because it has been open many days with no activity. It will be closed soon unless the stale label is removed or a comment is made. |
It should be possible to anticipate the next command. For example in case a rebase is needed due to multiple commits. In such case, it would be nice to already execute the command that is currently printed to the terminal:
It would be good to already run
git rebase origin/master -i -x "git node land --amend"
. Evengit node land --continue
should be possible to run automatically as soon as that's done.Removing the temporary files should also be done by default. A user might opt out by a config flag instead?
The text was updated successfully, but these errors were encountered: