Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove EoL Node.js 16 from test matrix #733

Merged
merged 4 commits into from
Sep 24, 2023

Conversation

rluvaton
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.03% ⚠️

Comparison is base (6d68c99) 83.03% compared to head (84fe43f) 83.00%.
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #733      +/-   ##
==========================================
- Coverage   83.03%   83.00%   -0.03%     
==========================================
  Files          37       37              
  Lines        4178     4184       +6     
==========================================
+ Hits         3469     3473       +4     
- Misses        709      711       +2     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Trott
Copy link
Member

Trott commented Sep 22, 2023

Can you please update the "engines" field in package.json as well?

@Trott
Copy link
Member

Trott commented Sep 22, 2023

Totally not necessary for this PR but optional here or as a future enhancement: If we use the pkgjs prepare-node-test-matrix GitHub Action instead of hardcoding the Node.js version numbers, it will look at the "engines" property in package.json and only test the LTS versions at or above that level along with the current version. See https://github.com/pkgjs/action/tree/main for more information. (pkgjs is the tooling org managed in a very hands-off way by the TSC for Node.js.)

@rluvaton
Copy link
Member Author

@Trott moved to prepare-node-test-matrix 😄

package.json Outdated Show resolved Hide resolved
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@aduh95 aduh95 merged commit b727af2 into nodejs:main Sep 24, 2023
8 of 9 checks passed
@rluvaton rluvaton deleted the remove-node-16-eol branch September 24, 2023 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants