Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI fails on Node.js 21 #752

Closed
targos opened this issue Nov 13, 2023 · 7 comments · Fixed by #761
Closed

CI fails on Node.js 21 #752

targos opened this issue Nov 13, 2023 · 7 comments · Fixed by #761

Comments

@targos
Copy link
Member

targos commented Nov 13, 2023

See https://github.com/nodejs/node-core-utils/actions/runs/6847526575/job/18615958948?pr=751

@targos
Copy link
Member Author

targos commented Nov 13, 2023

@nodejs/test_runner Is there a way to execute the test runner with arguments that work in all supported Node.js versions?

@targos
Copy link
Member Author

targos commented Nov 26, 2023

@MoLow Do you know of a solution?

@MoLow
Copy link
Member

MoLow commented Nov 26, 2023

not a good one.
I would try changing the command based on the node version,
we can also run node --test $(find . -name 'test/unit/**.js' | tr '\n' ' ') which will be compatible for all versions

@targos
Copy link
Member Author

targos commented Nov 27, 2023

This is unfortunate. Isn't it a big issue for adoption of the test runner by projects that want to support all release lines?

@MoLow
Copy link
Member

MoLow commented Nov 27, 2023

It probably is, we should have probably thought about that - although this change was a semver major change, and was necessary since it made it possibe to run typescript tests or tests other then the default pattern

@aduh95
Copy link
Contributor

aduh95 commented Nov 28, 2023

I guess we could backport it behind a --experimental-glob-in-test-runner flag or something like that

@ljharb
Copy link
Member

ljharb commented Nov 28, 2023

Major changes for a test runner built into the platform will always cause this problem; the only solution is to never have them, or, not have a test runner that’s built in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants