Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ci): use shell expansion to run test files #761

Merged
merged 1 commit into from
Dec 8, 2023
Merged

fix(ci): use shell expansion to run test files #761

merged 1 commit into from
Dec 8, 2023

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Dec 6, 2023

Fixes: #752

@codecov Codecov
Copy link

codecov bot commented Dec 6, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7df1d0c) 82.93% compared to head (6b1fe14) 82.93%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #761   +/-   ##
=======================================
  Coverage   82.93%   82.93%           
=======================================
  Files          37       37           
  Lines        4191     4191           
=======================================
  Hits         3476     3476           
  Misses        715      715

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aduh95
Copy link
Contributor Author

aduh95 commented Dec 6, 2023

Blocked on rvagg/ghauth#31

@aduh95 aduh95 requested a review from targos December 8, 2023 12:48
targos
targos approved these changes Dec 8, 2023
View reviewed changes
Copy link
Member

@targos targos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM assuming we don't want to support Windows.

@aduh95
Copy link
Contributor Author

aduh95 commented Dec 8, 2023

Yeah not sure why the CI doesn't run on Windows. I think it should work on Windows as long as you're using Node.js 21+ to run the tests.

@aduh95 aduh95 merged commit dbd8c65 into nodejs:main Dec 8, 2023
11 checks passed
@aduh95 aduh95 deleted the test-21.x branch December 8, 2023 12:56
@github-actions github-actions bot mentioned this pull request Dec 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@targos targos targos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI fails on Node.js 21
2 participants
@aduh95 @targos